Bug 432087 - Empty space on top of User Feedback KCM can produce unnecessary scroll bar depending on screen resolution
Summary: Empty space on top of User Feedback KCM can produce unnecessary scroll bar de...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_feedback (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
: 429497 437869 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-01-25 10:38 UTC by Patrick Silva
Modified: 2021-06-02 17:40 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.22
Sentry Crash Report:


Attachments
screen recording (1.09 MB, video/webm)
2021-01-25 10:38 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-01-25 10:38:26 UTC
Created attachment 135157 [details]
screen recording

SUMMARY
Vertical space of my 1366x768 screen is enough to show the whole content of
User Feedback KCM, but currently there is an empty space on top of this KCM
that produces a unnecessary scroll bar. Watch the attached screen recording please.

STEPS TO REPRODUCE
1. open User Feedback KCM using a machine with 1366x768 screen
2. 
3. 

EXPECTED RESULT
empty space on top of User Feedback KCM should be removed, so unnecessary
scroll bar will not be produced when a 1366x768 screen is used.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.21.80
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2
Comment 1 Nate Graham 2021-06-02 15:43:11 UTC
Ah, it's because of this:

leftPadding: width * 0.1

Internally, SimpleKCM uses the left padding for the top, right, and bottom padding too. So we need to either override top and bottom padding to be less, or stop doing this.
Comment 2 Nate Graham 2021-06-02 15:46:01 UTC
Git commit 6170e045e25fd236123331b8cd5bce6230964403 by Nate Graham.
Committed on 02/06/2021 at 15:44.
Pushed by ngraham into branch 'master'.

[kcms/feedback] Remove unnecessarily large margins

Instead, add extra margins only where needed: to the explanatory text
itself.
FIXED-IN: 5.22

M  +7    -5    kcms/feedback/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/6170e045e25fd236123331b8cd5bce6230964403
Comment 3 Nate Graham 2021-06-02 15:46:36 UTC
Git commit 980add1826598573e0ab74f480fa9ccba04ad42b by Nate Graham.
Committed on 02/06/2021 at 15:46.
Pushed by ngraham into branch 'Plasma/5.22'.

[kcms/feedback] Remove unnecessarily large margins

Instead, add extra margins only where needed: to the explanatory text
itself.
FIXED-IN: 5.22
(cherry picked from commit 6170e045e25fd236123331b8cd5bce6230964403)

M  +7    -5    kcms/feedback/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/980add1826598573e0ab74f480fa9ccba04ad42b
Comment 4 Nate Graham 2021-06-02 15:47:01 UTC
*** Bug 437869 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2021-06-02 17:40:48 UTC
*** Bug 429497 has been marked as a duplicate of this bug. ***