Bug 431995 - Plasma System Monitor widget won't align properly on vertical panel + buggy "show title" toggle
Summary: Plasma System Monitor widget won't align properly on vertical panel + buggy "...
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Neon Linux
: HI normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-23 15:30 UTC by yamiyukisenpai
Modified: 2021-02-11 11:29 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
What the widget looks like (2.39 KB, image/png)
2021-01-23 15:30 UTC, yamiyukisenpai
Details

Note You need to log in before you can comment on or make changes to this bug.
Description yamiyukisenpai 2021-01-23 15:30:40 UTC
Created attachment 135098 [details]
What the widget looks like

SUMMARY
The widget's graph won't properly align, mainly the pie chart, and the "show title" toggle doesn't work

OBSERVED RESULT
Other graphs seems to align to the edge just fine.

Disabling "Show Title" won't disable the title on Pie Chart.  In order to remove it, the title has to be erased.  Although the opposite is true for horizontal bar where graph doesn't show the title at all.
 

EXPECTED RESULT
I expected the Pie chart won't overflow outside the panel, and the "show title" toggle to work as expected 

SOFTWARE/OS VERSIONS
Operating System: KDE neon Testing Edition
KDE Plasma Version: 5.20.90
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2
Kernel Version: 5.8.0-40-generic
OS Type: 64-bit
Processors: 4 × Intel® Core™ i5-6500 CPU @ 3.20GHz
Memory: 15.6 GiB of RAM
Graphics Processor: GeForce GTX 1060 6GB/PCIe/SSE2

ADDITIONAL INFORMATION
This is on Latte Dock.  I haven't tried on normal Plasma panel.
Comment 1 Arjen Hiemstra 2021-02-11 11:27:49 UTC
Git commit 458d973eb973413e5274de7bbdde74ec0ac779a5 by Arjen Hiemstra.
Committed on 09/02/2021 at 13:14.
Pushed by ahiemstra into branch 'master'.

Respect "show title" flag for Faces' CompactRepresentation

This was missed when initially implementing the support

M  +4    -2    faces/facepackages/barchart/contents/ui/CompactRepresentation.qml
M  +4    -2    faces/facepackages/linechart/contents/ui/CompactRepresentation.qml
M  +4    -2    faces/facepackages/piechart/contents/ui/CompactRepresentation.qml

https://invent.kde.org/plasma/libksysguard/commit/458d973eb973413e5274de7bbdde74ec0ac779a5
Comment 2 Arjen Hiemstra 2021-02-11 11:27:57 UTC
Git commit 119a69767c3c2246e42f43d54090bba27338c07d by Arjen Hiemstra.
Committed on 11/02/2021 at 11:23.
Pushed by ahiemstra into branch 'master'.

Ensure text doesn't flow outside the Pie Chart face

When the pie chart gets smaller, we now hide certain parts of the text
to ensure things are not peeking outside the pie chart. This prevents
glitches when used in a Plasma panel for example.

M  +1    -1    faces/facepackages/piechart/contents/ui/CompactRepresentation.qml
M  +3    -5    faces/facepackages/piechart/contents/ui/PieChart.qml
M  +69   -32   faces/facepackages/piechart/contents/ui/UsedTotalDisplay.qml

https://invent.kde.org/plasma/libksysguard/commit/119a69767c3c2246e42f43d54090bba27338c07d
Comment 3 Arjen Hiemstra 2021-02-11 11:28:57 UTC
Git commit 73fdb19da87537db0e11ed52ec2efe1fdb44cb4d by Arjen Hiemstra.
Committed on 11/02/2021 at 11:28.
Pushed by ahiemstra into branch 'Plasma/5.21'.

Respect "show title" flag for Faces' CompactRepresentation

This was missed when initially implementing the support


(cherry picked from commit 458d973eb973413e5274de7bbdde74ec0ac779a5)

M  +4    -2    faces/facepackages/barchart/contents/ui/CompactRepresentation.qml
M  +4    -2    faces/facepackages/linechart/contents/ui/CompactRepresentation.qml
M  +4    -2    faces/facepackages/piechart/contents/ui/CompactRepresentation.qml

https://invent.kde.org/plasma/libksysguard/commit/73fdb19da87537db0e11ed52ec2efe1fdb44cb4d
Comment 4 Arjen Hiemstra 2021-02-11 11:29:24 UTC
Git commit c033ee22ea1589579d2198d8eb892c1fa4a1a05a by Arjen Hiemstra.
Committed on 11/02/2021 at 11:29.
Pushed by ahiemstra into branch 'Plasma/5.21'.

Ensure text doesn't flow outside the Pie Chart face

When the pie chart gets smaller, we now hide certain parts of the text
to ensure things are not peeking outside the pie chart. This prevents
glitches when used in a Plasma panel for example.


(cherry picked from commit 119a69767c3c2246e42f43d54090bba27338c07d)

M  +1    -1    faces/facepackages/piechart/contents/ui/CompactRepresentation.qml
M  +3    -5    faces/facepackages/piechart/contents/ui/PieChart.qml
M  +69   -32   faces/facepackages/piechart/contents/ui/UsedTotalDisplay.qml

https://invent.kde.org/plasma/libksysguard/commit/c033ee22ea1589579d2198d8eb892c1fa4a1a05a