Bug 431969 - Horizontal line at the top of the some players
Summary: Horizontal line at the top of the some players
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: general (show other bugs)
Version: 5.20.90
Platform: Arch Linux Other
: HI normal
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-01-23 03:17 UTC by Rind
Modified: 2021-01-28 20:54 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/breeze/commit/f4e854aeb8d9f026f3dd7bab8d31662db10be172
Version Fixed In: 5.21

Attachments
screenshot (33.93 KB, image/jpeg)
2021-01-23 03:18 UTC, Rind 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Rind 2021-01-23 03:17:58 UTC 
STEPS TO REPRODUCE
1. Play a video with smplayer
2. Maximize 

OBSERVED RESULT
Until now I was able to play this bug with two different players: SMPlayer and mpc-qt
Using mpv without any interface in qt does not cause this bug

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.20.90
KDE Frameworks Version: 5.78.0
Qt Version: 5.15.2
Kernel Version: 5.10.9-arch1-1
OS Type: 64-bit
Comment 1 Rind 2021-01-23 03:18:27 UTC 
Created attachment 135080 [details]
screenshot
Comment 2 Nicolas Fella 2021-01-23 09:35:14 UTC 

*** This bug has been marked as a duplicate of bug 431904 ***
Comment 3 Nate Graham 2021-01-28 14:23:38 UTC 
Not a duplicate of Bug 431904; that one is a general complaint about the line existing at all, while this one is a legitimate bug about the line appearing at the top of full-screen video players. Re-opening.
Comment 4 Nate Graham 2021-01-28 14:25:09 UTC 
There is a merge requests that attempts to fix this: https://invent.kde.org/plasma/breeze/-/merge_requests/71

However it's not working for me. Let's follow up there.
Comment 5 David Edmundson 2021-01-28 16:53:35 UTC 
The presence of a line is a minor visual. Moving from VHI
Comment 6 Nate Graham 2021-01-28 17:28:10 UTC 
IMO it's not a minor visual when you're taking about a full-screen video window. In that context, it's really distracting. Would recommend reconsidering VHI -> HI change.
Comment 7 Janet Blackquill 2021-01-28 20:51:45 UTC 
Git commit c3e2d0b777149d3393467565e869e53f47f1caaf by Jan Blackquill.
Committed on 28/01/2021 at 20:08.
Pushed by ngraham into branch 'master'.

[kstyle]: Don't draw line when no toolbars are present in fullscreen

Since there's no titlebar to draw a separator under, a separator just looks strange.

M  +4    -1    kstyle/breezestyle.cpp
M  +1    -1    kstyle/breezetoolsareamanager.cpp

https://invent.kde.org/plasma/breeze/commit/c3e2d0b777149d3393467565e869e53f47f1caaf
Comment 8 Nate Graham 2021-01-28 20:53:57 UTC 
Git commit f4e854aeb8d9f026f3dd7bab8d31662db10be172 by Nate Graham, on behalf of Jan Blackquill.
Committed on 28/01/2021 at 20:53.
Pushed by ngraham into branch 'Plasma/5.21'.

[kstyle]: Don't draw line when no toolbars are present in fullscreen

Since there's no titlebar to draw a separator under, a separator just looks strange.


(cherry picked from commit c3e2d0b777149d3393467565e869e53f47f1caaf)

M  +4    -1    kstyle/breezestyle.cpp
M  +1    -1    kstyle/breezetoolsareamanager.cpp

https://invent.kde.org/plasma/breeze/commit/f4e854aeb8d9f026f3dd7bab8d31662db10be172