Bug 431930 - GTK4 apps cannot be maximized fully due to window shadow still being visible
Summary: GTK4 apps cannot be maximized fully due to window shadow still being visible
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: gtk theme (show other bugs)
Version: 5.20.90
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Janet Blackquill
URL: https://gitlab.gnome.org/GNOME/gtk/-/...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-22 12:03 UTC by Matej Mrenica
Modified: 2021-01-28 21:21 UTC (History)
5 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/breeze-gtk/commit/15bc5576f5e1a9ee01d1a79396984b539eb8ae87
Version Fixed In: 5.21

Attachments
Screenshot (170.23 KB, image/png)
2021-01-22 12:03 UTC, Matej Mrenica 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Matej Mrenica 2021-01-22 12:03:57 UTC 
Created attachment 135061 [details]
Screenshot

SUMMARY
When a gtk4 app is maximized, there is some space left all around the window.

STEPS TO REPRODUCE
1. Start gtk4-demo
2. maximize

SOFTWARE/OS VERSIONS
KDE Frameworks Version: 5.78
Qt Version: 5.15.2
Comment 1 Matej Mrenica 2021-01-22 12:06:27 UTC 
A report on GTK bug tracker suggests this is a theming issue not a GTK issue. For more info see: https://gitlab.gnome.org/GNOME/gtk/-/issues/3608
Comment 2 Nate Graham 2021-01-22 16:11:10 UTC 
Looks like its shadow is being included in the window size calculation. It should probably be removed for maximized windows.

Not sure this is a theme issue or a GTK issue.
Comment 3 Nicolas Fella 2021-01-22 16:18:05 UTC 
Are you using X11 or Wayland?

Works fine for me with Nautilus on X11, both with Adwaita and Breeze
Comment 4 Nate Graham 2021-01-22 16:19:20 UTC 
Note that this bug is about the GTK4 versions of those apps.
Comment 5 Nicolas Fella 2021-01-22 16:23:47 UTC 
I can confirm this with gtk4-demo on X11 and Breeze. With adwaita it works fine
Comment 6 Bug Janitor Service 2021-01-28 20:42:40 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze-gtk/-/merge_requests/15
Comment 7 Janet Blackquill 2021-01-28 21:14:30 UTC 
Git commit 96c2f79c272a25f759b2530a9cfa377f276952e0 by Jan Blackquill.
Committed on 28/01/2021 at 21:12.
Pushed by cblack into branch 'master'.

gtk4: remove margin on windows

This isn't /r/unixporn and we want our windows to touch the edges of the screen when maximized. GTK4 is nice enough to automatically adjust the size of surfaces and whatnot when we set a box shadow, so we don't have to use a margin hack in order to make room for it in the first place.

M  +5    -2    src/gtk4/widgets/_window_decorations.scss

https://invent.kde.org/plasma/breeze-gtk/commit/96c2f79c272a25f759b2530a9cfa377f276952e0
Comment 8 Janet Blackquill 2021-01-28 21:21:25 UTC 
Git commit 15bc5576f5e1a9ee01d1a79396984b539eb8ae87 by Jan Blackquill.
Committed on 28/01/2021 at 21:21.
Pushed by cblack into branch 'Plasma/5.21'.

gtk4: remove margin on windows

This isn't /r/unixporn and we want our windows to touch the edges of the screen when maximized. GTK4 is nice enough to automatically adjust the size of surfaces and whatnot when we set a box shadow, so we don't have to use a margin hack in order to make room for it in the first place.
FIXED-IN: 5.21

M  +5    -2    src/gtk4/widgets/_window_decorations.scss

https://invent.kde.org/plasma/breeze-gtk/commit/15bc5576f5e1a9ee01d1a79396984b539eb8ae87