Bug 431859 - Mouse cursor should disappear whenever you are over top of the canvas.
Summary: Mouse cursor should disappear whenever you are over top of the canvas.
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush Engine/Bristle (show other bugs)
Version: 4.4.2-beta1
Platform: Android ChromeOS
: NOR normal
Target Milestone: ---
Assignee: sh_zam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-20 18:39 UTC by Luc
Modified: 2021-09-23 08:57 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Before and after required fix (822.95 KB, image/png)
2021-01-20 18:39 UTC, Luc
Details
Wacom_strokes log (579.24 KB, text/plain)
2021-09-13 12:38 UTC, Luc
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Luc 2021-01-20 18:39:10 UTC
Created attachment 135025 [details]
Before and after required fix

When using a mouse over the canvas area, the mouse cursor remains displayed while drawing besides the actual brush symbol used. The cursor is very distracting when drawing.

Although most won't use a mouse to draw, a Wacom drawing pad behaves as a mouse even when using the physical pen. Recently, Wacom was just accommodated for pen pressure (hooray!), so this is an important piece of the puzzle to fully support Wacom tablets on ChromeOS.

Obviously this should only be fixed when over the canvas area since we still need a mouse cursor for menus and such.

Merci.
Comment 1 Halla Rempt 2021-01-20 19:13:01 UTC
Please tell us exactly which version of ChromeOS and what hardware you are using.
Comment 2 Luc 2021-01-20 19:52:28 UTC
(In reply to Halla Rempt from comment #1)
> Please tell us exactly which version of ChromeOS and what hardware you are
> using.

For sure.

I'm using an official Google Pixel Slate. Latest stable version: Version 87.0.4280.142 (Official Build) (64-bit)

For input, this happens using my built in trackpad, external Logitech mouse or the external Wacom Intuos 4 drawing tablet. There is NO problem if I use my official Pixelbook Pen. But the goal is to have the cursor removed when using the Wacom drawing tablet of course. At least I'm hoping this is possible.

For reference, another contributor just added pen pressure sensitivity using a Wacom tablet. This is the bug where I was reporting back to the person. It JUST got resolved. https://bugs.kde.org/show_bug.cgi?id=429940

We actually have two Slates in the household. My wife (the actual artist) is currently using the Krita version from the Play Store. I (the tech guy) am using an experimental version 5.0.0-prealpha (git 21f70cc). It was given to me to test the pressure sensitivity for the Wacom tablet as per that bug report.

Point is, more than happy to do any testing required. I can install these experimental versions if needed for testing. 

Thanks for responding.
Comment 3 Bug Janitor Service 2021-01-21 04:33:19 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 4 Luc 2021-01-26 13:02:12 UTC
In case this matters, here's what just got published. https://gizmodo.com/wacoms-cheapest-tablet-now-supports-chromebooks-for-asp-1846128080
Comment 5 Luc 2021-01-26 13:40:32 UTC
And another article with some different info. https://chromeunboxed.com/one-by-wacom-graphics-tablet-chromebooks

Wacom support with Krita for Android on a Chromebook really sounds it may become reasonably popular! May be worth investing more time in supporting Wacom properly on Chromebooks.

Regardless, thanks to everyone making Krita awesome!
Comment 6 Halla Rempt 2021-09-10 10:27:53 UTC
Sharaf, is this still the case?
Comment 7 Luc 2021-09-10 11:44:00 UTC
(In reply to Halla Rempt from comment #6)
> Sharaf, is this still the case?

Hi, original reporter of this issue. I have Krita 5.0.0 beta 1 installed on my Google Pixel Slate. I just tried the Wacom drawing pad again and same thing. Cursor is still there.
Comment 8 sh_zam 2021-09-13 11:32:46 UTC
Hello Luc!

Could you please try to capture the Tablet Log
(https://docs.krita.org/en/contributors_manual/user_support.html#gathering-information)
for 5.0.0 beta 1 and attach it? I'd like to check what sort of events
are passed down to Qt by Android.

Also, because you can't change cursor for some device types. I want to
verify if tablet events' cursor is something which could be changed on
ChromeOS. Could you please test this [1] app and see if the cursor
changes as you hover over the items. The app is from
https://github.com/chromeos/pointer-icon-sample

[1]: https://drive.google.com/file/d/115ZjKRIipMtqRUQwCTxWU8l5JI3YjvR4/view?usp=sharing
Comment 9 Luc 2021-09-13 12:38:47 UTC
Created attachment 141513 [details]
Wacom_strokes log
Comment 10 Luc 2021-09-13 12:39:18 UTC
Hi again, attached is the log requested. 

I had a look at that github set of files, but I'm unsure how to install it since it's not an apk. I am NOT a master of Linux, ChromeOS, etc. But I can definitely do a few things with some guidance. I do have Linux installed, and was able to install an apk... but this github repository doesn't have what I'm familiar with.

Note that I'm pretty sure the cursor wasn't there in an older version of Krita before pen pressure was added. But don't quote me on that... it's been a long time.
Comment 11 sh_zam 2021-09-13 13:07:01 UTC
(In reply to Luc from comment #10)
> I had a look at that github set of files, but I'm unsure how to install it
> since it's not an apk. I am NOT a master of Linux, ChromeOS, etc. But I can
> definitely do a few things with some guidance. I do have Linux installed,
> and was able to install an apk... but this github repository doesn't have
> what I'm familiar with.

Oh, I have attached the google drive link where I have built the project into an APK. Sharing the link again: https://drive.google.com/file/d/115ZjKRIipMtqRUQwCTxWU8l5JI3YjvR4/view?usp=sharing
Comment 12 Luc 2021-09-13 13:11:38 UTC
I'm an idiot. Thank you. Installed and can confirm all the icons switch as I move my cursor over each one. Clever little "app". lol
Comment 13 sh_zam 2021-09-13 13:14:33 UTC
Thanks for confirming!
Comment 14 sh_zam 2021-09-21 10:39:33 UTC
Git commit 2fbcbaaed90ebf5987db926f75edd42ea1175d34 by Sharaf Zaman.
Committed on 21/09/2021 at 10:34.
Pushed by szaman into branch 'master'.

Android: Add support for changing cursor icon using QCursor

A  +377  -0    3rdparty/ext_qt/0001-Android-Add-support-for-changing-cursor.patch
M  +1    -0    3rdparty/ext_qt/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/2fbcbaaed90ebf5987db926f75edd42ea1175d34
Comment 15 sh_zam 2021-09-21 10:41:10 UTC
Hello!

I've fixed the bug. Could you please test this APK: https://drive.google.com/file/d/1XUz8YrYQRUs6C-xzrs19OH39XjTIOzqD/view?usp=sharing? I've signed it with my key, you may need to uninstall the previous version of Krita.
Comment 16 Luc 2021-09-21 11:54:51 UTC
I can confirm it works!

I did notice that when the cursor moves into the grey area in between the white page and the menus, there is no cursor, just the brush symbol. The problem is the cursor almost disappears since it's extremely subtle on the grey background. Not sure if it's possible, but I'd suggest the cursor should switch when off the white page instead. Because right now, you lose track of where it went.
Comment 17 sh_zam 2021-09-23 08:57:41 UTC
Git commit 2d3c9ebdf3cc556d1023cfc7bbde82bece659e90 by Sharaf Zaman.
Committed on 23/09/2021 at 08:32.
Pushed by szaman into branch 'krita/5.0'.

Android: Add support for changing cursor icon using QCursor
(cherry picked from commit 2fbcbaaed90ebf5987db926f75edd42ea1175d34)

A  +377  -0    3rdparty/ext_qt/0001-Android-Add-support-for-changing-cursor.patch
M  +1    -0    3rdparty/ext_qt/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/2d3c9ebdf3cc556d1023cfc7bbde82bece659e90