Bug 431765 - run_tests.py fail when clazy-standalone traverses a symbolic link
Summary: run_tests.py fail when clazy-standalone traverses a symbolic link
Status: RESOLVED FIXED
Alias: None
Product: clazy
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-18 00:10 UTC by Francisco Boni
Modified: 2021-01-24 07:17 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Francisco Boni 2021-01-18 00:10:05 UTC
Clazy-standalone outputs the complete *.cpp file path. Normalizing it so it compares OK with the expected output by using os.getcwd() (run_tests.py:554) doesn't work if the source root is traversed via symbolic link path

/insilications/apps/symbolic_link/tests $ ./run_tests.py --verbose

Qt version: 51500
Qt headers: /usr/include/qt5
clang -Xclang -load -Xclang ClazyPlugin.so -Xclang -add-plugin -Xclang clazy  -Wno-unused-value -Qunused-arguments -std=c++14 -isystem /usr/include/qt5 -fPIC -L /usr/lib64 -c  -Xclang -plugin-arg-clazy -Xclang post-event post-event/main.cpp
Running: clazy-standalone function-args-by-ref/main.cpp  -export-fixes=function-args-by-ref/main.cpp.clazy-standalone.yaml -checks=function-args-by-ref  -- -Wno-unused-value -Qunused-arguments -std=c++14 -isystem /usr/include/qt5 -fPIC -L /usr/lib64
output_file=function-args-by-ref/main.cpp.out
[FAIL] function-args-by-ref/main.cpp (standalone)
diff -Naur --strip-trailing-cr function-args-by-ref/main.cpp.expected function-args-by-ref/main.cpp.result
--- function-args-by-ref/main.cpp.expected      2021-01-17 19:04:36.916670022 -0300
+++ function-args-by-ref/main.cpp.result        2021-01-17 20:01:05.948949841 -0300
@@ -1,18 +1,18 @@
-function-args-by-ref/main.cpp:245:10: warning: 'virtualMethod2' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
-function-args-by-ref/main.cpp:28:10: warning: Missing reference on non-trivial type (const struct NonTrivial) [-Wclazy-function-args-by-ref]
+/insilications/apps/symbolic_link/tests/function-args-by-ref/main.cpp:245:10: warning: 'virtualMethod2' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
+/insilications/apps/symbolic_link/tests/function-args-by-ref/main.cpp:28:10: warning: Missing reference on non-trivial type (const struct NonTrivial) [-Wclazy-function-args-by-ref]



Their physical path:

/insilications/clazy/tests/function-args-by-ref/main.cpp.expected:
function-args-by-ref/main.cpp:245:10: warning: 'virtualMethod2' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
function-args-by-ref/main.cpp:28:10: warning: Missing reference on non-trivial type (const struct NonTrivial) [-Wclazy-function-args-by-ref]

/insilications/clazy/tests/function-args-by-ref/main.cpp.result:
/insilications/apps/symbolic_link/tests/function-args-by-ref/main.cpp:245:10: warning: 'virtualMethod2' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
/insilications/apps/symbolic_link/tests/function-args-by-ref/main.cpp:28:10: warning: Missing reference on non-trivial type (const struct NonTrivial) [-Wclazy-function-args-by-ref]
Comment 1 Francisco Boni 2021-01-18 00:26:39 UTC
Proposed fix: https://invent.kde.org/sdk/clazy/-/merge_requests/32
Comment 2 Francisco Boni 2021-01-24 07:17:54 UTC
Merged: https://invent.kde.org/sdk/clazy/-/merge_requests/32