Bug 431755 - Krita continues running in the background after closing session manager
Summary: Krita continues running in the background after closing session manager
Status: CONFIRMED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 4.4.1
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-17 20:45 UTC by tomtomtomreportingin
Modified: 2023-08-14 14:05 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tomtomtomreportingin 2021-01-17 20:45:53 UTC
SUMMARY
After closing the session manager at startup, Krita will continue to run in the background and this will prevent new instances.

STEPS TO REPRODUCE
1. Enable showing the session manager at startup in General -> Miscellaneous.
2. Restart Krita.
3. When the session manager appears, close it.

OBSERVED RESULT
Krita continues to run in the background.

EXPECTED RESULT
Krita should properly exit.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian sid
(available in About System)
KDE Plasma Version: 5.20.4
KDE Frameworks Version: 5.77.0
Qt Version: 5.12.9 (Appimage)
Comment 1 Halla Rempt 2021-01-18 13:18:41 UTC
What do you mean with "the session manager"? And where do you find "General -> Miscellaneous"?
Comment 2 tomtomtomreportingin 2021-01-18 21:08:51 UTC
You can enable the session manager by going to Settings -> Configure Krita -> General -> Miscellaneous tab -> When Krita starts: Show session manager.
Comment 3 Halla Rempt 2021-01-18 21:20:35 UTC
Ah, thanks for the clarification! I had completely forgotten about that feature... And yes, I can confirm the issue, Krita keeps running. Thanks for the report :-)
Comment 4 Tiar 2021-03-22 17:20:29 UTC
> 3. When the session manager appears, close it.
> Krita should properly exit.

By "running in the background" I guess you mean that there is no window open, but the Krita process is somewhere on the system running?
Is that really the expected behaviour that Krita would close? I mean I would expect Krita in that case to just open fully with no images open.
Comment 5 tomtomtomreportingin 2021-03-22 17:48:38 UTC
I'm not sure what behavior would be preferable as I don't really use this feature.

Currently:
* Double-clicking a session opens the session and closes the session manager.
* The "Switch to" button opens the session and leaves the session manager open. Closing that session manager leaves the Krita session open.
* Hitting the x-button or Close without any Krita session open leaves Krita running as a background process that must be killed with ksysguard or so on.

I would suggest adding a "Default session" button that would perform the way you described, and making close actions (when a session isn't already running) not leave behind a background process.
Comment 6 Tiar 2021-03-22 21:06:36 UTC
I think that would be the best option, too. Maybe not "Default session" but "Empty session" though, since default suggests that there is a session that you marked as default, while empty clearly says that it will be empty.
Comment 7 Alvin Wong 2023-08-14 14:04:41 UTC
Git commit b93943afaba69b3038e29c1ff49cfb4656e9ebd6 by Alvin Wong.
Committed on 14/08/2023 at 16:04.
Pushed by alvinwong into branch 'master'.

Show main window when closing session manager

Don't just leave the Krita process running in the background, give the
user something to work with.

M  +6    -0    libs/ui/dialogs/KisSessionManagerDialog.cpp

https://invent.kde.org/graphics/krita/-/commit/b93943afaba69b3038e29c1ff49cfb4656e9ebd6
Comment 8 Alvin Wong 2023-08-14 14:05:03 UTC
Git commit b294f3b28f2b42151725855dc77422f252049fd7 by Alvin Wong.
Committed on 14/08/2023 at 16:04.
Pushed by alvinwong into branch 'krita/5.2'.

Show main window when closing session manager

Don't just leave the Krita process running in the background, give the
user something to work with.
(cherry picked from commit b93943afaba69b3038e29c1ff49cfb4656e9ebd6)

M  +6    -0    libs/ui/dialogs/KisSessionManagerDialog.cpp

https://invent.kde.org/graphics/krita/-/commit/b294f3b28f2b42151725855dc77422f252049fd7