Bug 431627 - The strings "Meta Information" and "Image Information" were probably in each others' places
Summary: The strings "Meta Information" and "Image Information" were probably in each ...
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (other bugs)
Version First Reported In: 20.12.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-15 08:17 UTC by Tyson Tan
Modified: 2021-05-05 03:23 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 21.08
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2021-01-15 08:17:35 UTC
The following strings:

Meta Information
#: app/infocontextmanageritem.cpp:246

Image Information
imagemetainfodialog.cpp

were probably placed incorrectly.

"Meta Information" is currently displayed on the sidebar, under it are the filename and image size. Those fit better under the term of "Image information" rather than "Meta Information".

"Image Information" is currently displayed as the title of the dialogue that can be accessed from the "More..." link of the sidebar. However, that dialogue shows real meta information.

Although they can still work as is, maybe swapping their places serves our purpose better. Image Information sounds less intimidating too.
Comment 1 Nate Graham 2021-05-04 17:18:01 UTC
Git commit a3d02cf10138af884b6bff2b8f6873aecc68a785 by Nate Graham, on behalf of Noah Davis.
Committed on 04/05/2021 at 17:17.
Pushed by ngraham into branch 'master'.

InfoContextManagerItem: use indent not contentMargins for indenting, change text and position of "More...", adjust margins, change title

M  +6    -6    app/infocontextmanageritem.cpp

https://invent.kde.org/graphics/gwenview/commit/a3d02cf10138af884b6bff2b8f6873aecc68a785
Comment 2 Tyson Tan 2021-05-05 02:34:43 UTC
Thank you Nate! :D
Comment 3 Nate Graham 2021-05-05 03:13:43 UTC
You should thank Noah; he's the one who did it. :) I just clicked the Merge button!
Comment 4 Tyson Tan 2021-05-05 03:23:19 UTC
Yes, Thank Noah too. I actually saw Noah's name in the commit info, but I was interrupt and completely forgot about it later when I was writing comment 2. My bad XD