Bug 431602 - "Show current track" functionality has broken
Summary: "Show current track" functionality has broken
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: VHI normal
Target Milestone: ---
Assignee: Nate Graham
Keywords: regression
: 431822 (view as bug list)
Depends on:
Reported: 2021-01-14 17:19 UTC by Nate Graham
Modified: 2021-01-26 05:41 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 20.12.2


Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2021-01-14 17:19:00 UTC
Clicking its button displays this in console output:

qrc:/qml/MediaPlayListView.qml:143: TypeError: Property 'positionViewAtIndex' of object PlayListBasicView_QMLTYPE_186(0x25f0880) is not a function

grep reveals that the function seems to have been removed or renamed:

nate@Liberator:~/kde/src/elisa$  (master) grep -ri positionViewAtIndex
src/qml/DraggableItem.qml:251:            _listView.positionViewAtIndex(model.index, ListView.Contain);
src/qml/MediaPlayListView.qml:143:                        playListView.currentItem.positionViewAtIndex(ElisaApplication.mediaPlayListProxyModel.currentTrackRow, ListView.Contain)
Comment 1 Nate Graham 2021-01-14 17:43:07 UTC
Git bisect says I broke this in 3b80b0001239f8c6a35f95ff940e6ba596075310.

Will fix ASAP.
Comment 2 Bug Janitor Service 2021-01-14 17:54:54 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/211
Comment 3 Matthieu Gallien 2021-01-15 18:12:39 UTC
Git commit afaf25d815763728ac842922dd422377f66079dc by Matthieu Gallien, on behalf of Nate Graham.
Committed on 15/01/2021 at 16:12.
Pushed by mgallien into branch 'release/20.12'.

Fix "show current track" button

I broke this in 3b80b0001239f8c6a35f95ff940e6ba596075310 by making
PlayListBasicView into a ScrollView, not a ListView. Therefore anything
that wants to target properties and functions of the list view item
needs to be adjusted to do so explicitly.
FIXED-IN: 20.12.2

M  +3    -3    src/qml/MediaPlayListView.qml
M  +1    -0    src/qml/PlayListBasicView.qml

Comment 4 Nate Graham 2021-01-26 05:41:24 UTC
*** Bug 431822 has been marked as a duplicate of this bug. ***