Breeze ships with a number of different override icons for KeePassXC: 1. A normal colourful one: https://raw.githubusercontent.com/KDE/breeze-icons/master/icons/apps/48/keepassxc.svg 2. A monochrome version: https://raw.githubusercontent.com/KDE/breeze-icons/master/icons/status/22/keepassxc-unlocked.svg 3. A monochrome version with an orange padlock: https://raw.githubusercontent.com/KDE/breeze-icons/master/icons/status/22/keepassxc-locked.svg We are not particularly happy with the way these icons were designed. The main flaws are: The colourful variant is using the wrong green tone and the shading is totally off (particularly the direction of the background gradient is wrong). If you want to provide a shaded override icon, please base it on our shaded macOS icon (without the background of course): https://github.com/keepassxreboot/keepassxc/blob/develop/share/macosx/keepassxc.iconset/icon_512x512%402x.png The monochrome variant has totally wrong proportions and the orange padlock doesn't fit the style at all. We have different versions for light and dark themes, which have been carefully adjusted for legibility even at low resolutions. In fact, our version has much higher fidelity and works better at small tray sizes than the highly simplified Breeze icon, which to me looks rather glitchy. Mind you, the light variant is not simply a colour-inverted dark variant. It is shape-inverted. See: https://github.com/keepassxreboot/keepassxc/tree/develop/share/icons/application/scalable/apps We are trying not to allow custom overrides for our icons, but Plasma seems to be ignoring that request and shows the Breeze overrides anyway. Generally, we would prefer not to be overridden by third-party icons at all, but if you need to show custom icons, please stick closer to the original and consider my requests. Personally, I have deleted the Breeze overrides from my system.
Not knowing anything about keepasxc or wanting to comment on the actual issue here: How are you "trying not to allow custom overrides for our icons, but Plasma seems to be ignoring that request and shows the Breeze overrides anyway.?"
The icons that are currently in the breeze theme follow the patterns of existing breeze icons. When you're making pixel aligned 16x16 icon (with 2px margins, effectively 12x12) or 22x22 icons (with 3px margins, effectively 16x16), you usually can't stay completely true to the original proportions. If you try to shrink your upstream monochrome icons down to 16x16 or 22x22, you'll see that your pixel alignment is not as good and the margins do not match breeze icons. I'm confused about this request. If you want to enforce the use of your upstream icons, you should be able to do that without any help from us. As far as I know, we do not force apps to use breeze-icons.
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/74
> I'm confused about this request. If you want to enforce the use of your upstream icons, you should be able to do that without any help from us. As far as I know, we do not force apps to use breeze-icons. Icons within the application are no problem. But this is about the launcher and tray icons, which are taken from the system theme no matter what. > A possibly relevant merge request was started @ https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/74 Thanks
> Icons within the application are no problem. But this is about the launcher > and tray icons, which are taken from the system theme no matter what. > FWIW I looked into the tray and saw that you set the "IconThemePath" property which is not specified but wildly used. There was an attempt to specify it and you can find emails proposing it by googling. The Plasma code for that makes a bunch of assumptions about the structure of the icon theme you pass which I think do not fit your icon folder. I am not sure who is wrong here. See https://invent.kde.org/plasma/plasma-workspace/-/blob/master/dataengines/statusnotifieritem/statusnotifieritemsource.cpp#L233 Of course this doesn't matter with the above MR :)
Git commit 0ee909f19e86811f94df2a72f17d73f317a9cbfd by Nicolas Fella. Committed on 17/01/2021 at 21:03. Pushed by nicolasfella into branch 'master'. Remove KeePassXC icons Upstream asked us to remove those. D +0 -36 icons-dark/apps/48/keepassxc.svg D +0 -15 icons-dark/status/22/keepassxc-locked.svg D +0 -1 icons-dark/status/22/keepassxc-monochrome-dark-locked.svg D +0 -1 icons-dark/status/22/keepassxc-monochrome-dark.svg D +0 -8 icons-dark/status/22/keepassxc-unlocked.svg D +0 -36 icons/apps/48/keepassxc.svg D +0 -15 icons/status/22/keepassxc-locked.svg D +0 -1 icons/status/22/keepassxc-monochrome-light-locked.svg D +0 -1 icons/status/22/keepassxc-monochrome-light.svg D +0 -8 icons/status/22/keepassxc-unlocked.svg https://invent.kde.org/frameworks/breeze-icons/commit/0ee909f19e86811f94df2a72f17d73f317a9cbfd
Thanks. I know this request is a bit strange perhaps, so thank you for removing the icons regardless. I love the Breeze theme in general, but the KeePassXC icons didn't quite transport the visuals of our branding. I wouldn't know that we are actively setting IconThemePath anywhere. If anything, it's Qt doing that under the hood.