Bug 431540 - White line between toolbar and main content in Konsole
Summary: White line between toolbar and main content in Konsole
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: QStyle (show other bugs)
Version: unspecified
Platform: Other Linux
: HI normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-01-13 13:09 UTC by David Redondo
Modified: 2021-02-04 02:54 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21


Attachments
picture (8.69 KB, image/png)
2021-01-13 13:09 UTC, David Redondo
Details
Gwenview (327.22 KB, image/png)
2021-02-03 16:35 UTC, David Redondo
Details
Okular (40.88 KB, image/png)
2021-02-03 16:35 UTC, David Redondo
Details
Current Konsole (27.96 KB, image/png)
2021-02-03 16:36 UTC, David Redondo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Redondo 2021-01-13 13:09:47 UTC
Created attachment 134803 [details]
picture

Everything from master

See attached picture
Comment 1 Noah Davis 2021-01-13 14:41:11 UTC
It seems to only be present when a toolbar is enabled. If only the menu bar is present, the line isn't there.
Comment 2 Noah Davis 2021-01-13 14:44:41 UTC
It seems to be using the window background color. Kate and Dolphin also have the extra line of pixels below the header line when a toolbar is enabled, but it doesn't look like a bug then because it blends in.
Comment 3 David Redondo 2021-02-03 16:10:08 UTC
I see the same in Okular and in Gwenview. Has that something to do with the contentsMargins thing?
Comment 4 Janet Blackquill 2021-02-03 16:13:34 UTC
Yes, that's where the tools area border is going to be drawn.
Comment 5 David Redondo 2021-02-03 16:35:26 UTC
Created attachment 135395 [details]
Gwenview
Comment 6 David Redondo 2021-02-03 16:35:57 UTC
Created attachment 135396 [details]
Okular
Comment 7 David Redondo 2021-02-03 16:36:51 UTC
Created attachment 135397 [details]
Current Konsole
Comment 8 David Redondo 2021-02-03 16:37:33 UTC
(In reply to Jan Blackquill (Carson Black) from comment #4)
> Yes, that's where the tools area border is going to be drawn.

I added some pictures that show that the white line actually shows up beneath the border.
Comment 9 Nate Graham 2021-02-03 18:42:50 UTC
Yeah this isn't a problem in the case where the pixel below the line matches the view background, but it shows up as a bright line in cases when it doesn't. We should fix this. Preferably before the final release.
Comment 10 Bug Janitor Service 2021-02-03 21:39:38 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze/-/merge_requests/77
Comment 11 Janet Blackquill 2021-02-04 02:53:38 UTC
Git commit 4f844aef09c8e7c5e689a9070a5bfb3d9cb4c3b2 by Jan Blackquill.
Committed on 04/02/2021 at 02:50.
Pushed by cblack into branch 'master'.

kstyle: expand tools area 1px downwards if present

Border shenanigans mean that the tools area is 1px less than it should be. Incrementing it fixes this.

M  +3    -0    kstyle/breezetoolsareamanager.cpp

https://invent.kde.org/plasma/breeze/commit/4f844aef09c8e7c5e689a9070a5bfb3d9cb4c3b2
Comment 12 Janet Blackquill 2021-02-04 02:54:34 UTC
Git commit ec08c8415e9f1425dff7cc11a8aed73d48bd722e by Jan Blackquill.
Committed on 04/02/2021 at 02:54.
Pushed by cblack into branch 'Plasma/5.21'.

kstyle: expand tools area 1px downwards if present

Border shenanigans mean that the tools area is 1px less than it should be. Incrementing it fixes this.

M  +3    -0    kstyle/breezetoolsareamanager.cpp

https://invent.kde.org/plasma/breeze/commit/ec08c8415e9f1425dff7cc11a8aed73d48bd722e