Bug 431433 - Can't see holiday content in calendar
Summary: Can't see holiday content in calendar
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Calendar (show other bugs)
Version: 5.20.4
Platform: Other Linux
: HI normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
: 423149 429203 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-01-11 12:28 UTC by medin
Modified: 2021-01-11 17:43 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21
Sentry Crash Report:


Attachments
Can't see holiday content in calendar (29.80 KB, image/png)
2021-01-11 12:28 UTC, medin
Details
Expected screenshot (209.19 KB, image/png)
2021-01-11 14:07 UTC, Nicolas Fella
Details

Note You need to log in before you can comment on or make changes to this bug.
Description medin 2021-01-11 12:28:02 UTC
Created attachment 134735 [details]
Can't see holiday content in calendar

I use minimal KDE with Manjaro because akonadi slows my machine and I don't have any need for any akonadi related app, but when I set in Digital Clock settings to show holidays, they are marked in calendar but when I click on any holiday its content is not displayed and there's no tooltip to show it. See attached image for more info.

Operating System: Manjaro Linux
KDE Plasma Version: 5.20.4
KDE Frameworks Version: 5.77.0
Qt Version: 5.15.2
Kernel Version: 5.10.2-2-MANJARO
OS Type: 64-bit
Comment 1 Nicolas Fella 2021-01-11 14:07:16 UTC
It should display a sidebar with the event detail (see my screenshot).

However it seems to fail to load that if you just enabled the holidays. Can you reboot or run "plasmashell --replace" and check again?
Comment 2 Nicolas Fella 2021-01-11 14:07:36 UTC
Created attachment 134736 [details]
Expected screenshot
Comment 3 medin 2021-01-11 15:14:20 UTC
(In reply to Nicolas Fella from comment #1)
> It should display a sidebar with the event detail (see my screenshot).
> 
> However it seems to fail to load that if you just enabled the holidays. Can
> you reboot or run "plasmashell --replace" and check again?

You are right, after running "plasmashell --replace" it shows the holiday detail at right side. Is it normal for a widget to require whole plasmashell to restart ?
Comment 4 Bug Janitor Service 2021-01-11 15:14:40 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/566
Comment 5 Nicolas Fella 2021-01-11 15:19:57 UTC
(In reply to medin from comment #3)
> (In reply to Nicolas Fella from comment #1)
>Is it normal for a widget to require whole plasmashell
> to restart ?

No, there is just a very subtle issue preventing it from working correctly
Comment 6 medin 2021-01-11 15:26:50 UTC
(In reply to Nicolas Fella from comment #5)
> (In reply to medin from comment #3)
> > (In reply to Nicolas Fella from comment #1)
> >Is it normal for a widget to require whole plasmashell
> > to restart ?
> 
> No, there is just a very subtle issue preventing it from working correctly

Thanks ;)
Comment 7 Nate Graham 2021-01-11 16:52:51 UTC
*** Bug 429203 has been marked as a duplicate of this bug. ***
Comment 8 Nate Graham 2021-01-11 16:52:53 UTC
*** Bug 423149 has been marked as a duplicate of this bug. ***
Comment 9 Nicolas Fella 2021-01-11 17:22:00 UTC
Git commit 56064d80ff2e798460967b28243c8117ee6ebaec by Nicolas Fella.
Committed on 11/01/2021 at 15:16.
Pushed by nicolasfella into branch 'master'.

[applets/digitalclock] Fix showing agenda view when enabling plugins

The agenda view is only shown when at least one event source is active.
When going from 0 to 1 active sources the view wasn't updated correctly.

This was because the visibility of rightColumn was bound to the
visibility of its child, but since the visibility of the parent affects
the visibility of its childred (https://doc.qt.io/qt-5/qml-qtquick-item.html#visible-prop) that resulted in a broken binding.

Bind to the source property directly to avoid this

M  +1    -1    applets/digital-clock/package/contents/ui/CalendarView.qml

https://invent.kde.org/plasma/plasma-workspace/commit/56064d80ff2e798460967b28243c8117ee6ebaec
Comment 10 Nicolas Fella 2021-01-11 17:28:10 UTC
Git commit aa5215a0b3f8febfe9eda2ab586d9bf8ba647c7c by Nicolas Fella.
Committed on 11/01/2021 at 17:22.
Pushed by nicolasfella into branch 'Plasma/5.20'.

[applets/digitalclock] Fix showing agenda view when enabling plugins

The agenda view is only shown when at least one event source is active.
When going from 0 to 1 active sources the view wasn't updated correctly.

This was because the visibility of rightColumn was bound to the
visibility of its child, but since the visibility of the parent affects
the visibility of its childred (https://doc.qt.io/qt-5/qml-qtquick-item.html#visible-prop) that resulted in a broken binding.

Bind to the source property directly to avoid this
(cherry picked from commit 56064d80ff2e798460967b28243c8117ee6ebaec)

M  +1    -1    applets/digital-clock/package/contents/ui/CalendarView.qml

https://invent.kde.org/plasma/plasma-workspace/commit/aa5215a0b3f8febfe9eda2ab586d9bf8ba647c7c
Comment 11 Nate Graham 2021-01-11 17:43:54 UTC
No need to backport since there aren't any more Plasma 5.20 released planned. :)