SUMMARY createdoctemplates.sh does not work with modern versions of docbookl10nhelper, expects kde-custom-l10n.xml to exist. Modern versions of docbookl10nhelper do not generate the file kde-custom-l10n.xml anymore, see source code at https://invent.kde.org/frameworks/kdoctools/-/blob/master/src/docbookl10nhelper.cpp However createdoctemplates.sh (https://invent.kde.org/sysadmin/l10n-scripty/-/blob/master/createdoctemplates.sh) expects that file to exist and fails otherwise, see lines 34-36: if test -z "${DOCBOOK_L10N_ALL}" || test -z "${DOCBOOK_L10N_CUSTOM}"; then echo "No custom l10n files for DocBook XSLT were found. Exiting..." exit 1 Same problem at https://invent.kde.org/sysadmin/l10n-scripty/-/blob/master/checkdocs.sh#L13: DOCBOOK_L10N_CUSTOM="$kdoctoolsdir/src/customization/xsl/kde-custom-l10n.xml" STEPS TO REPRODUCE 1. 2. 3. OBSERVED RESULT EXPECTED RESULT SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION
This one is for Luigi
Only --checks (and checkdocs.sh) doesn't work, otherwise scripty would have been totally broken. Still need to be fixed.
--check is used at https://invent.kde.org/sysadmin/l10n-scripty/-/blob/master/update_translations#L422: bash $scriptydir/createdoctemplates.sh --commit --check --autosvnadd I can't explain why scripty is not broken.
Unless I read it incorrectly (and it may), test -z only checks that the string is not empty - and indeed it is not - and not for the file existence (that would be `if ! test -f ${FILE_FOO} || ! test -f ${FILE_BAR}; then`). So while the condition should be fixed, the code still works as it is.
Ah, right. Sorry for confusion.