Bug 431398 - Double click to select word
Summary: Double click to select word
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: 5.19.5
Platform: Kubuntu Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2021-01-10 15:58 UTC by xcojack@gmail.com
Modified: 2021-01-30 17:50 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.22.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description xcojack@gmail.com 2021-01-10 15:58:33 UTC
SUMMARY
I can not select word by double click on it.

STEPS TO REPRODUCE
1. Get notification
2. Double click on word
3. Doesn't work

OBSERVED RESULT
It just select one letter

EXPECTED RESULT
I should select word. Very helpful with 2FA like sms  messages where your phone is connected via KDE Connect <3

SOFTWARE/OS VERSIONS
Windows: nope
macOS: nope
Linux/KDE Plasma: Linux cojack-desktop 5.8.0-36-generic #40-Ubuntu SMP Tue Jan 5 21:54:35 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
(available in About System)
KDE Plasma Version: 5.19.5
KDE Frameworks Version: 5.74.0
Qt Version: 5.14.2

ADDITIONAL INFORMATION
I love KDE <3
Comment 1 Nate Graham 2021-01-11 22:58:49 UTC
Confirmed. I find myself very slightly annoyed by this when I want to select and copy a one-time code from a website doing 2-factor authentication.
Comment 2 Kai Uwe Broulik 2021-01-24 10:43:10 UTC
The question is whether we want to "jeopardize" the activation of a notification, i.e. if you click, wait for a potential double click (or triple click) before activating it. Unless, we only care about non-activatable notifications, like the ones synced from KDE Connect.
Comment 3 Bug Janitor Service 2021-01-27 23:07:58 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/602
Comment 4 Kai Uwe Broulik 2021-01-30 17:50:20 UTC
Git commit 97022f2f67c269cec2660ae4690e527cf452b322 by Kai Uwe Broulik.
Committed on 30/01/2021 at 17:50.
Pushed by broulik into branch 'master'.

[Notifications] Don't steal mouse clicks from TextEdit in SelectableLabel

Ensures built-in functionality like double- and triple-clicking text works.

Also lets us get rid of the custom text selection handling, replacing it with
an even filter class.
FIXED-IN: 5.22.0

M  +1    -0    applets/notifications/CMakeLists.txt
M  +2    -0    applets/notifications/notificationapplet.cpp
M  +1    -1    applets/notifications/package/contents/ui/NotificationItem.qml
M  +2    -1    applets/notifications/package/contents/ui/NotificationPopup.qml
M  +22   -54   applets/notifications/package/contents/ui/SelectableLabel.qml
A  +70   -0    applets/notifications/texteditclickhandler.cpp     [License: LGPL (v2.1+)]
A  +57   -0    applets/notifications/texteditclickhandler.h     [License: LGPL (v2.1+)]

https://invent.kde.org/plasma/plasma-workspace/commit/97022f2f67c269cec2660ae4690e527cf452b322