Bug 431354 - Inconsistent behavior when adding Tags/Keywords
Summary: Inconsistent behavior when adding Tags/Keywords
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Menus (show other bugs)
Version: 7.2.0
Platform: Flatpak Linux
: NOR minor
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-09 15:03 UTC by MarcP
Modified: 2021-02-06 18:22 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.2.0
Sentry Crash Report:


Attachments
Screen capture showing the issue (972.98 KB, image/gif)
2021-01-09 15:03 UTC, MarcP
Details

Note You need to log in before you can comment on or make changes to this bug.
Description MarcP 2021-01-09 15:03:41 UTC
Created attachment 134684 [details]
Screen capture showing the issue

SUMMARY

Hi, I noticed a minor but inconsistent behavior when tagging pictures in the Captions/Tags panel.

Basically, if you select a picture, and type a Tag that does not exist on the tree, that tag will appear immediately in the Tag tree (prior to hitting Apply). however, if the tag already exists, the tag won't appear in that picture until saves are changed to the file.

I think a good compromise would be showing the temporal tag ("assigned", but not yet Applied) in another color, like grey, to indicate it has just been assigned.

PS: I was only able to try this while the "Tags already assigned" button is on, as it would be impossible to check due to the thousands of tags present in my tree.

STEPS TO REPRODUCE
I have created a screen capture recording to show the behavior. See attachment.


SOFTWARE/OS VERSIONS
Digikam 7.2.0 from Flatpak Build date: Jan 9 2021 (target: Debug)
Rev.: c3077451a517fb160e0e25a9991a279948610500
Comment 1 Maik Qualmann 2021-01-09 15:17:04 UTC
You have filtered the tag tree on the right to only show tags that are present in the image, since the tag "Aquari" has no arrow to expand. Your new tag will therefore only be displayed when you assign it.

Maik
Comment 2 MarcP 2021-01-09 15:19:04 UTC
Yes, but it's filtered in both cases, either when the tag already exists in the tree, and when it doesn't. 

Shouldn't digikam behave equally in both cases?

In any case, I think it would be more intuitive to show the newly unsaved tag in another color, to highlight what has just been added and it's about to be written.
Comment 3 Maik Qualmann 2021-02-06 18:22:57 UTC
Git commit e50d6bffc51212fa56016a6a83b9bdcd62dd49ed by Maik Qualmann.
Committed on 06/02/2021 at 18:21.
Pushed by mqualmann into branch 'master'.

show new assigned tags in the filtered tags view
Related: bug 432568
FIXED-IN: 7.2.0

M  +3    -1    NEWS
M  +8    -0    core/libs/models/albumfiltermodel.cpp
M  +5    -0    core/libs/models/albumfiltermodel.h
M  +1    -0    core/libs/properties/captions/itemdescedittab.cpp
M  +5    -0    core/libs/tags/widgets/tagcheckview.cpp

https://invent.kde.org/graphics/digikam/commit/e50d6bffc51212fa56016a6a83b9bdcd62dd49ed