Bug 431298 - Okular_Nightly_win64 not working from 1 Dec
Summary: Okular_Nightly_win64 not working from 1 Dec
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-08 10:48 UTC by dapa1
Modified: 2021-05-20 19:59 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description dapa1 2021-01-08 10:48:14 UTC 
SUMMARY
Windows nightlies are broken from 1st Dec 2020.

STEPS TO REPRODUCE
1. Navigate to https://binary-factory.kde.org/job/Okular_Nightly_win64/
2. Latest succesful build is #5​91 (Nov 30, 2020).
3. Subsequent builds complain on okular\generators\spectre\generator_ghostview.h(16): fatal error C1083: Cannot open include file: 'libspectre/spectre.h'.

OBSERVED RESULT
No newer nightly after 30th of November.

EXPECTED RESULT
Windows nightlies should work. 


SOFTWARE/OS VERSIONS
Windows:  Windows 10 Enterprise (1909, 64-bit).

ADDITIONAL INFORMATION
On some enterprise machines Microsoft Store is disabled, therefore only option is https://binary-factory.kde.org/job/Okular_Nightly_win64/
Can someone fix it, please?
Comment 1 Vito De Tullio 2021-05-18 15:50:14 UTC 
Sorry, just asking: is this the reason the windows store version is updated to release "20.12.2" and not on 21.04?
Comment 2 Christoph Cullmann 2021-05-18 16:19:42 UTC 
Yes, as no 21.04 build was there that worked since then.
(if I didn't miss that)
Comment 3 Albert Astals Cid 2021-05-18 19:15:04 UTC 
FWIW this is not an Okular issue, this is a craft issue that builds libspectre wrong.
Comment 4 Ben Cooksley 2021-05-19 09:55:34 UTC 
@Albert - Mind detailing what Craft is doing wrong here with the libspectre build?

https://invent.kde.org/packaging/craft-blueprints-kde/-/blob/master/libs/libspectre/libspectre.py
Comment 5 Albert Astals Cid 2021-05-19 16:47:07 UTC 
The fact that it's rolling out its own build system https://invent.kde.org/packaging/craft-blueprints-kde/-/blob/master/libs/libspectre/spectre-0.2.1-cmake.diff
Comment 6 Hannah von Reth 2021-05-19 17:11:43 UTC 
I'm sorry that there are platforms besides gnu linux.

Is spectre one of those few packages that support autotools with msvc?
Comment 7 Albert Astals Cid 2021-05-19 18:06:08 UTC 
We've discussed this in the IRC channel not more than a month ago, I don't know and i don't care if spectre support autotools with msvc.

You're free to use your own buildsystem, but if you do, your buildsytem should be compatible with the real one, and it doesn't seem to be, because otherwise it wouldn't fail to find the include path?

Hmmm, thought maybe the problem is actually in Okular, i'll have a second look later.
Comment 8 Albert Astals Cid 2021-05-19 20:53:08 UTC 
Ok, will probably be fixed by https://invent.kde.org/graphics/okular/-/merge_requests/432
Comment 9 Ben Cooksley 2021-05-20 09:03:14 UTC 
Thanks for investigating that - I can confirm the build is now fixed.
https://binary-factory.kde.org/job/Okular_Nightly_win64/
Comment 10 Hannah von Reth 2021-05-20 09:14:26 UTC 
Thx