Bug 431295 - KWin rules kcm does not fokus search field when adding a new property
Summary: KWin rules kcm does not fokus search field when adding a new property
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_kwinrules (show other bugs)
Version: 5.20.5
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
: 433330 433985 (view as bug list)
Depends on: 433991
Blocks:
  Show dependency tree / graph
 
Reported: 2021-01-08 09:18 UTC by Till Schäfer
Modified: 2021-03-30 15:35 UTC (History)
6 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/kirigami/commit/21de2a2912839a7076623910025ff88c5cc31c2e
Version Fixed In: 5.81
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Till Schäfer 2021-01-08 09:18:36 UTC 
When pressing/clicking "Add Properties..." via the novel kwin rules kcm, it is not possible to immediately start typing to search the properties. Thus, I propose to focus the search field as soon the property list pops up. 


Operating System: Gentoo Linux
KDE Plasma Version: 5.20.5
KDE Frameworks Version: 5.77.0
Qt Version: 5.15.2
Kernel Version: 5.10.5-gentoo
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-4810MQ CPU @ 2.80GHz
Memory: 15.5 GiB of RAM
Graphics Processor: Mesa DRI Intel® HD Graphics 4600
Comment 1 Justin Zobel 2021-01-15 00:15:25 UTC 
Thanks for the suggestion, seems like a sane idea to me. Set to wishlist.
Comment 2 Ismael Asensio 2021-03-05 08:52:31 UTC 
*** Bug 433985 has been marked as a duplicate of this bug. ***
Comment 3 Ismael Asensio 2021-03-05 08:53:06 UTC 
*** Bug 433330 has been marked as a duplicate of this bug. ***
Comment 4 David Edmundson 2021-03-28 10:18:53 UTC 
Git commit 21de2a2912839a7076623910025ff88c5cc31c2e by David Edmundson.
Committed on 28/03/2021 at 10:18.
Pushed by davidedmundson into branch 'master'.

Fix focus handling in OverlaySheet to be managed as one FocusScope

Focus handling inside OverlaySheet had some issues, namely:
- if the contentItem was a flickable, we would be calling
forceActiveFocus on the unused invisible container for non-flickables
(contentItemParent)

 -ScrollArea was a non-focus scope that has focus set by default,
this meant it could take focus arbitrarily

This moves the FocusScope to the toplevel visible item

M  +32   -26   src/controls/templates/OverlaySheet.qml

https://invent.kde.org/frameworks/kirigami/commit/21de2a2912839a7076623910025ff88c5cc31c2e