Bug 431222 - No redo when transforming
Summary: No redo when transforming
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Transform (show other bugs)
Version: 4.4.1
Platform: macOS (DMG) macOS
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-06 11:54 UTC by Manga Tengu
Modified: 2021-04-06 11:28 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/graphics/krita/commit/4b738c5572f3fbe2dcb2c947a7e2502a02487ccc
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Manga Tengu 2021-01-06 11:54:01 UTC 
While transforming, we can undo in-transformation steps but not redo them.
Is there a reason or is it just omitted ? Would be great to be able to redo so we can toggle before/after before validating the transformation.
Comment 1 Tiar 2021-01-06 14:52:35 UTC 
I'm confirming, I've found the same yesterday.
Comment 2 Bug Janitor Service 2021-04-05 13:26:41 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/792
Comment 3 Dmitry Kazakov 2021-04-06 11:28:46 UTC 
Git commit 4b738c5572f3fbe2dcb2c947a7e2502a02487ccc by Dmitry Kazakov, on behalf of Sharaf Zaman.
Committed on 06/04/2021 at 11:27.
Pushed by dkazakov into branch 'master'.

Implement redo for intermediate transform+move states

For sake of simplicity redo states are in a separate stack.

M  +21   -2    libs/ui/tool/KisToolChangesTracker.cpp
M  +2    -1    libs/ui/tool/KisToolChangesTracker.h
M  +9    -2    plugins/tools/basictools/kis_tool_move.cc
M  +1    -0    plugins/tools/basictools/kis_tool_move.h
M  +11   -3    plugins/tools/tool_transform2/kis_tool_transform.cc
M  +1    -0    plugins/tools/tool_transform2/kis_tool_transform.h

https://invent.kde.org/graphics/krita/commit/4b738c5572f3fbe2dcb2c947a7e2502a02487ccc