Bug 431043 - String puzzles in the CalendarController class
Summary: String puzzles in the CalendarController class
Status: RESOLVED FIXED
Alias: None
Product: calindori
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources All
: NOR normal
Target Milestone: ---
Assignee: Dimitris Kardarakos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-01 21:51 UTC by Luigi Toscano
Modified: 2021-01-22 13:35 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:
luigi.toscano: Translation_missing+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Luigi Toscano 2021-01-01 21:51:49 UTC
SUMMARY
The CalendarControll class contains several string puzzles which makes those strings untranslatable.

A message should not be constructed by initializing partial strings and then composing them through "%1 %2", because that doesn't allow several languages to be translated, even if "%1 %2" was wrapped around an i18n call.

Please fix the way confirmMsg is constructed in this method:
https://invent.kde.org/plasma-mobile/calindori/-/blob/eff464d8aec5cb3bfb199d1639f450336023a257/src/calendarcontroller.cpp#L19

More details can be found here:
https://api.kde.org/frameworks/ki18n/html/prg_guide.html#good_text

There may be other string puzzles around too.
Comment 1 Dimitris Kardarakos 2021-01-22 13:35:50 UTC
Git commit fcb1a89368625ccad8009d9d45a1ef3d42a6851e by Dimitris Kardarakos.
Committed on 22/01/2021 at 13:32.
Pushed by dkardarakos into branch 'master'.

Solve string puzzles

This commit facilitates complex string translation by removing string puzzles

M  +4    -7    src/calendarcontroller.cpp
M  +15   -10   src/incidencealarmsmodel.cpp

https://invent.kde.org/plasma-mobile/calindori/commit/fcb1a89368625ccad8009d9d45a1ef3d42a6851e