Bug 431010 - KRunner history entries can't be selected anymore
Summary: KRunner history entries can't be selected anymore
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Milou (show other bugs)
Version: master
Platform: Other Linux
: VHI normal
Target Milestone: 1.0
Assignee: Alexander Lohnau
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-12-31 16:39 UTC by Nate Graham
Modified: 2020-12-31 19:15 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.21


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2020-12-31 16:39:16 UTC
Everything from git master.

Trying to select them results in the following console spam:

file:///home/nate/kde/usr/lib64/qml/org/kde/milou/ResultDelegate.qml:140: TypeError: Type error
file:///home/nate/kde/usr/lib64/qml/org/kde/milou/ResultDelegate.qml:140: TypeError: Type error
file:///home/nate/kde/usr/lib64/qml/org/kde/milou/ResultDelegate.qml:140: TypeError: Type error
file:///home/nate/kde/usr/lib64/qml/org/kde/milou/ResultDelegate.qml:140: TypeError: Type error
file:///home/nate/kde/usr/lib64/qml/org/kde/milou/ResultDelegate.qml:140: TypeError: Type error
file:///home/nate/kde/usr/lib64/qml/org/kde/milou/ResultDelegate.qml:140: TypeError: Type error
Comment 1 Alexander Lohnau 2020-12-31 16:46:24 UTC
Sure this is a recent regression? I remember that this is a long standing issue.
Comment 2 Nate Graham 2020-12-31 16:56:16 UTC
I'm not 100% sure but I recall it working for me the last time I checked fairly recently.
Comment 3 Bug Janitor Service 2020-12-31 17:06:24 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/milou/-/merge_requests/22
Comment 4 Alexander Lohnau 2020-12-31 17:55:12 UTC
Git commit 78134c262c23e67a061dae49d537adebf59589eb by Alexander Lohnau.
Committed on 31/12/2020 at 17:51.
Pushed by alex into branch 'master'.

Fix mouse interaction with history entries

In case of the history entries we do not have
a ResultView, but rather a normal QML list view.
Consequently special properties/methods do not
exist.

This has the only downside, that one can accidentally
focus one item with the mouse when the user tries to do
a keyboard only interaction. But considering that clearing
specific entries from the history is done rarely and mostly
done by clearing all entries in the KCM this should be acceptable.
FIXED-IN: 5.21

M  +2    -1    lib/qml/ResultDelegate.qml

https://invent.kde.org/plasma/milou/commit/78134c262c23e67a061dae49d537adebf59589eb
Comment 5 Nate Graham 2020-12-31 19:15:37 UTC
Wow, that was fast. :)