Bug 430991 - FTBFS: includes QPrinter, but doesn't link to QPrintSupport
Summary: FTBFS: includes QPrinter, but doesn't link to QPrintSupport
Status: RESOLVED FIXED
Alias: None
Product: tellico
Classification: Applications
Component: general (other bugs)
Version First Reported In: HEAD
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Robby Stephenson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-30 23:10 UTC by Christoph Feck
Modified: 2021-01-04 10:09 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Feck 2020-12-30 23:10:15 UTC
Trying to compile today's master on OpenSUSE build service, I get this error:

/home/abuild/rpmbuild/BUILD/tellico-3.4.40git211~ce881b9e/src/gui/../entryview.h:30:10: fatal error: QPrinter: No such file or directory

Not sure if this is caused by Qt cleanup or recent code changes. See also bug 368147.

Qt Version: 5.15.2
Comment 1 Robby Stephenson 2020-12-31 03:47:19 UTC
Git commit a0abca5e4a1f7682d03a8ce6bfb321832f7d8989 by Robby Stephenson.
Committed on 31/12/2020 at 03:46.
Pushed by rstephenson into branch 'master'.

Link to QPrintSupport

M  +4    -1    CMakeLists.txt
M  +1    -1    src/CMakeLists.txt

https://invent.kde.org/office/tellico/commit/a0abca5e4a1f7682d03a8ce6bfb321832f7d8989
Comment 2 Christoph Feck 2021-01-03 12:10:56 UTC
This only fixes it for the case when building with WebEngine instead of KHTML. If the latter is no longer supported, I suggest to remove the code for KHTML support.
Comment 3 Robby Stephenson 2021-01-03 19:44:57 UTC
Git commit 36fd4aaf50eea3f591a053736b45e3c9d9b687d3 by Robby Stephenson.
Committed on 03/01/2021 at 19:44.
Pushed by rstephenson into branch 'master'.

Fix compilation with KHTML

The intent is to still build with KHTML through all the 3.x releases.
Tellico did not explicitly link against QPrinterSupport previously when
building against KHTML so I wouldn't expect it to be necessary now.
If there's a KHTML scenario where Tellico 3.3 compiles but 3.4 does not
then please let me know.

M  +13   -4    src/entryview.cpp
M  +5    -8    src/entryview.h

https://invent.kde.org/office/tellico/commit/36fd4aaf50eea3f591a053736b45e3c9d9b687d3
Comment 4 Christoph Feck 2021-01-04 10:09:26 UTC
Merci :)