Bug 430892 - ./copy_from_breeze.sh does not work on openSUSE Leap 15.2
Summary: ./copy_from_breeze.sh does not work on openSUSE Leap 15.2
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: buildsystem (show other bugs)
Version: git (master)
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-28 10:34 UTC by Thomas Baumgart
Modified: 2020-12-28 11:55 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Baumgart 2020-12-28 10:34:13 UTC
SUMMARY


STEPS TO REPRODUCE
1. Run ./copy_from_breeze.sh <breeze-source-directory>

OBSERVED RESULT
prints error message

  sed: -e expression #1, char 59: Invalid content of \{\}

on console and does not copy the icons referenced in icons.cpp

EXPECTED RESULT
does not print error message and copies icons referenced in icons.cpp

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSUSE Leap 15.2
(available in About System)
KDE Plasma Version: 5.18.6
KDE Frameworks Version: 5.71.0
Qt Version: 5.12.7

ADDITIONAL INFORMATION
Comment 1 Thomas Baumgart 2020-12-28 11:55:56 UTC
Git commit 477b0da5921ddd8795422c3dfe5a03e4b2d78dff by Thomas Baumgart.
Committed on 28/12/2020 at 11:55.
Pushed by tbaumgart into branch 'master'.

Improve copy_from_breeze.sh

- Check arguments and print error messages
- Escape braces in sed substitution expression
- Remove trailing / from directory argument
- Check for presence of icons.cpp
- Allow to run out of any directory
- Convert files to *NIX line ending if tool available

M  +61   -11   kmymoney/icons/copy_from_breeze.sh

https://invent.kde.org/office/kmymoney/commit/477b0da5921ddd8795422c3dfe5a03e4b2d78dff