Bug 430843 - 20.12 New Subtitles Crash when using CTRL+C to copy them
Summary: 20.12 New Subtitles Crash when using CTRL+C to copy them
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Effects & Transitions (show other bugs)
Version: 20.12.0
Platform: Microsoft Windows Microsoft Windows
: NOR crash
Target Milestone: ---
Assignee: Vincent PINON
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-27 08:07 UTC by gohamo9200
Modified: 2021-01-05 16:39 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/multimedia/kdenlive/commit/7654f19f0e24b9be745f01b12a2169c8ff04b088
Version Fixed In: 20.12.1
fritzibaby: Brainstorm+

Attachments
crash error report (46.82 KB, image/jpeg)
2020-12-27 08:07 UTC, gohamo9200 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description gohamo9200 2020-12-27 08:07:55 UTC 
Created attachment 134343 [details]
crash error report

SUMMARY

the new subtitles feature is a welcome addition, however user intuition suggests that one would be able to copy paste them like another item in the time line. 

However when attempting this on Windows 7 64bit on the latest 20.12 kdenlive release the program crashes with the error,  
- This application has requested the runtime to terminate it in an unusual way

 And also becomes unresponsive and will have to be forced closed from task manager, I have Microsoft visual c++ 2005, 2008, 2010, 2012, 2013 and 2015-2019 of varying flavours installed.


STEPS TO REPRODUCE
1. open Kdenlive
2. add a subtitle
3. use ctrl+c to copy the subtitle box on the time line

OBSERVED RESULT
Application Crash

EXPECTED RESULT
To be able to copy and paste the subtitles ( from the news this update is still work in progress it seems but the fatal crash seems a bit buggy than just not being able to copy paste it.)

SOFTWARE/OS VERSIONS
Windows: 7


ADDITIONAL INFORMATION
A great addition to kdenlive and thank you to Sashmita Raghav for adding this feature.
Comment 1 emohr 2021-01-03 15:52:58 UTC 
Confirmed. Thanks for reporting. I opened issue https://invent.kde.org/multimedia/kdenlive/-/issues/906.
Comment 2 emohr 2021-01-03 18:57:59 UTC 
It's fixed for the moment until CTRL+C/CTRL+V get implemented. No crash anymore.
Comment 3 Jean-Baptiste Mardelle 2021-01-05 16:37:48 UTC 
Git commit fcb241737316cdec7997c1aba761e21b656d2dcd by Jean-Baptiste Mardelle.
Committed on 05/01/2021 at 16:37.
Pushed by mardelle into branch 'release/20.12'.

implement missing subtitle copy/paste.
Fixes #906

M  +13   -1    src/bin/model/subtitlemodel.cpp
M  +1    -0    src/bin/model/subtitlemodel.hpp
M  +1    -0    src/timeline2/model/groupsmodel.cpp
M  +34   -9    src/timeline2/model/timelinefunctions.cpp
M  +1    -0    src/timeline2/model/timelinemodel.cpp

https://invent.kde.org/multimedia/kdenlive/commit/fcb241737316cdec7997c1aba761e21b656d2dcd
Comment 4 Jean-Baptiste Mardelle 2021-01-05 16:39:28 UTC 
Git commit 7654f19f0e24b9be745f01b12a2169c8ff04b088 by Jean-Baptiste Mardelle.
Committed on 05/01/2021 at 16:39.
Pushed by mardelle into branch 'master'.

implement missing subtitle copy/paste.
Fixes #906

M  +13   -1    src/bin/model/subtitlemodel.cpp
M  +1    -0    src/bin/model/subtitlemodel.hpp
M  +1    -0    src/timeline2/model/groupsmodel.cpp
M  +34   -9    src/timeline2/model/timelinefunctions.cpp
M  +1    -0    src/timeline2/model/timelinemodel.cpp

https://invent.kde.org/multimedia/kdenlive/commit/7654f19f0e24b9be745f01b12a2169c8ff04b088