Bug 430717 - Don't allow searching with empty search string
Summary: Don't allow searching with empty search string
Status: CONFIRMED
Alias: None
Product: dolphin
Classification: Applications
Component: search (show other bugs)
Version: 20.08.3
Platform: Manjaro Linux
: NOR minor
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-22 19:40 UTC by Andrius
Modified: 2021-04-24 14:36 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrius 2020-12-22 19:40:22 UTC
SUMMARY
When searching empty search term, Dolphin displays all files in folder AND the parent folder

STEPS TO REPRODUCE
1. Open Dolphin
2. press Ctrl + F
3. press Enter

OBSERVED RESULT
parent folder is displayed on top of result list

EXPECTED RESULT
parent folder is not shown

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.20.4
KDE Frameworks Version: 5.76
Qt Version: 5.15.2
Comment 1 Nate Graham 2021-01-12 23:15:50 UTC
Never mind, I was confused, can't reproduce.

Regardless, an empty search term doesn't not really make any sense. We should prevent executing a search query when the search field is empty. If we fix that, the bug here gets fixed automatically, regardless of who can or can't reproduce it. :)
Comment 2 rvvl 2021-04-24 14:34:33 UTC
A merge request have been created today which fixes it. 

Ref:
https://invent.kde.org/system/dolphin/-/merge_requests/202
Comment 3 Stefan Brüns 2021-04-24 14:36:50 UTC
Of course its makes sense, you can still search for *all* files with a given tag, type, date, ... or any combination thereof.