Bug 430666 - https://commits.kde.org/kwin/bf5155f82b1655a98311a73fa466484862f1cd09 prevents minimize/maximize for some apps
Summary: https://commits.kde.org/kwin/bf5155f82b1655a98311a73fa466484862f1cd09 prevent...
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: core (other bugs)
Version First Reported In: git master
Platform: Other Linux
: VHI normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-12-21 14:42 UTC by Nate Graham
Modified: 2021-01-07 20:23 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2020-12-21 14:42:09 UTC 
https://invent.kde.org/plasma/kwin/-/commit/bf5155f82b1655a98311a73fa466484862f1cd09 causes KFind and Spectacle to no longer display minimize and maximize buttons in their titlebars. However they are still minimizble and maximizable using keyboard shortcuts, and maximizable by double-clicking the titlebar or dragging the window to the top edge of the screen
Comment 1 David Edmundson 2020-12-22 10:44:00 UTC 
xprop | grep _NET_WM_ALLOWED_ACTIONS 
_NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_SHADE, _NET_WM_ACTION_FULLSCREEN, _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_CLOSE

and clicking on spectacle.

So it's doing exactly what the client requested.


I checked why it's not set in spectacle. We inherit from qdialog, and that due to:

QWidgetPrivate::adjustFlags

    else if (type == Qt::Dialog || type == Qt::Sheet) {
        flags |= Qt::WindowTitleHint | Qt::WindowSystemMenuHint | Qt::WindowCloseButtonHint;
Comment 2 Kai Uwe Broulik 2021-01-07 19:42:14 UTC 
Git commit 6f6603eb64b945e39820a0658504041b851c6e8c by Kai Uwe Broulik.
Committed on 01/01/2021 at 15:34.
Pushed by davidedmundson into branch 'master'.

x11integration: Force standalone Qt::Dialog resizable

Because KWin now honors minimize/maximize button hint.

M  +21   -0    src/platformtheme/x11integration.cpp

https://invent.kde.org/plasma/plasma-integration/commit/6f6603eb64b945e39820a0658504041b851c6e8c