Bug 430553 - krita's existence loop kills the Finder
Summary: krita's existence loop kills the Finder
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: File formats (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: macOS (DMG) macOS
: NOR critical
Target Milestone: ---
Assignee: amyspark
URL:
Keywords: regression, release_blocker
Depends on:
Blocks:
 
Reported: 2020-12-18 19:34 UTC by Manga Tengu
Modified: 2020-12-19 13:06 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Manga Tengu 2020-12-18 19:34:40 UTC
SUMMARY
This is mac specific please don't do linux or windows experiments with that.

STEPS TO REPRODUCE
1. Build krita 64c051b39806dda22e9dd44b04557930a61a4786
2. Open krita
3. With the finder go to a folder containing .kra files

OBSERVED RESULT
Finder shuts down and can't restart even after restarting the computer
You need to "rm -rf /Applications/krita.app" and then the finder reappears.

SOFTWARE/OS VERSIONS
macOS: big shit euh sur

git hash is 64c051b39806dda22e9dd44b04557930a61a4786 as said above
Comment 1 Halla Rempt 2020-12-19 11:32:02 UTC
This sounds like it might have to do swith the updated macOS integration plugins. Since these commits are in krita/4.4.2, they are a regression and a release blocker. Amyspark, can you take a look?
Comment 2 Halla Rempt 2020-12-19 11:35:16 UTC
Ah, amyspark vacation -- I probably will revert the integration commits from krita/4.4.2 and test on my new mac.
Comment 3 amyspark 2020-12-19 12:32:13 UTC
I asked yesterday for a crash log, which hasn't been uploaded here. Anyway, I think the problem is the Quick Look Thumbnailing generator - I'll MR its removal in a pinch.
Comment 4 Manga Tengu 2020-12-19 12:35:42 UTC
I asked you on the channel which part of the log you wanted. This is a corporate computer and sharing whole crash logs is not allowed.
I still have the log and can still give you the parts you need. 
And as you guessed: 
Crashed Thread:        0  Dispatch queue: com.apple.quicklook.extensionmanager.accessextensions
Comment 5 Bug Janitor Service 2020-12-19 12:50:09 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/626
Comment 6 amyspark 2020-12-19 12:58:37 UTC
Git commit 4165f6fbf84a32364fd0d155c39baca8fbf07412 by L. E. Segovia.
Committed on 19/12/2020 at 12:47.
Pushed by rempt into branch 'master'.

Disable QuickLook Thumbnailing extension

It is the only extension that applies to Catalina onwards, and the bug
report says it takes down the Finder. As I don't have a crash report to
fix, let's just disable it for now.

It'll have to be revisited in the future, because QuickLook generators
themselves are deprecated.

M  +2    -1    krita/integration/CMakeLists.txt
M  +3    -2    packaging/macos/osxdeploy.sh

https://invent.kde.org/graphics/krita/commit/4165f6fbf84a32364fd0d155c39baca8fbf07412
Comment 7 Manga Tengu 2020-12-19 13:02:42 UTC
If I'm not wrong this was not backported on the 4.3 branch which is the one I encountered the bug with.
Comment 8 amyspark 2020-12-19 13:05:54 UTC
Git commit 3740597f3b0220232d7cf0f99cc6f6b56ed028f8 by L. E. Segovia.
Committed on 19/12/2020 at 13:04.
Pushed by lsegovia into branch 'krita/4.3'.

Disable QuickLook Thumbnailing extension

It is the only extension that applies to Catalina onwards, and the bug
report says it takes down the Finder. As I don't have a crash report to
fix, let's just disable it for now.

It'll have to be revisited in the future, because QuickLook generators
themselves are deprecated.
(cherry picked from commit 4165f6fbf84a32364fd0d155c39baca8fbf07412)

M  +2    -1    krita/integration/CMakeLists.txt
M  +3    -2    packaging/macos/osxdeploy.sh

https://invent.kde.org/graphics/krita/commit/3740597f3b0220232d7cf0f99cc6f6b56ed028f8
Comment 9 amyspark 2020-12-19 13:06:43 UTC
Git commit 3e1ef6893e6990011f93de76ae174e64e4aa5882 by L. E. Segovia.
Committed on 19/12/2020 at 13:06.
Pushed by lsegovia into branch 'krita/4.4.2'.

Disable QuickLook Thumbnailing extension

It is the only extension that applies to Catalina onwards, and the bug
report says it takes down the Finder. As I don't have a crash report to
fix, let's just disable it for now.

It'll have to be revisited in the future, because QuickLook generators
themselves are deprecated.
(cherry picked from commit 4165f6fbf84a32364fd0d155c39baca8fbf07412)

M  +2    -1    krita/integration/CMakeLists.txt
M  +3    -2    packaging/macos/osxdeploy.sh

https://invent.kde.org/graphics/krita/commit/3e1ef6893e6990011f93de76ae174e64e4aa5882