Bug 430490 - twitch.tw irc still issues who command despite logic to counter that
Summary: twitch.tw irc still issues who command despite logic to counter that
Status: RESOLVED WORKSFORME
Alias: None
Product: konversation
Classification: Applications
Component: protocol (show other bugs)
Version: 1.7.7
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-17 03:32 UTC by Wren Turkal
Modified: 2020-12-21 20:13 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Redacted raw log from konversation showing the behavior (1.55 KB, text/plain)
2020-12-17 03:32 UTC, Wren Turkal
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wren Turkal 2020-12-17 03:32:31 UTC
Created attachment 134132 [details]
Redacted raw log from konversation showing the behavior

SUMMARY
When connecting to a twitch.tv irc server, the WHO command should not be issued over and over again since the twitch.tv irc servers do not support that command.


STEPS TO REPRODUCE
1. Create an account on twitch.
2. Open Koversation.
3. Goto Server List
4. Add a new server connection
  * Server info
    * server/port: irc.chat.twitch.tv:6697
    * ssl: checked
  * Identity info
    * username: your twitch user name
    * auto identify type: Server Password
    * password: oauth key from twitch.tv irc setup
5. Connect to twitch.tv irc server


OBSERVED RESULT
The WHO command is sent once per minute.


EXPECTED RESULT
The WHO command is not sent.


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: don't know
KDE Frameworks Version: 5.77.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
* Line of code that attempts to alter who logic for twitch irc servers: https://invent.kde.org/network/konversation/-/blob/master/src/irc/server.cpp#L782
* Here's info on connecting to the twitch irc servers: https://dev.twitch.tv/docs/irc/guide
* It appears that logic was added to handle this in https://invent.kde.org/network/konversation/-/commit/e4085aed8e38b9d665aa1efd1c38fb0cfe593da7, so I'd love to see this updated to work.
Comment 1 Peter Simonsson 2020-12-20 08:45:59 UTC
You need to use version 20.12 (large change in release number due to switch to KDE's release service) for the workaround to be present.

https://download.kde.org/stable/release-service/20.12.0/src/konversation-20.12.0.tar.xz

There doesn't seem to be a binary available yet for Fedora unfortunately.
Comment 2 Wren Turkal 2020-12-21 18:59:51 UTC
Thanks for the info. Great to hear that it's already fixed.
Comment 3 Ahmad Samir 2020-12-21 20:13:03 UTC
(Filing a bug report with your distro usually results in the package maintainers either backporting the fix or updating to the new version).