Bug 430465 - Add Crop option in annotation tool
Summary: Add Crop option in annotation tool
Status: RESOLVED FIXED
Alias: None
Product: Spectacle
Classification: Applications
Component: General (show other bugs)
Version: 20.12.0
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: Antonio Prcela
URL:
Keywords:
: 428143 438108 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-12-16 16:31 UTC by Nowshed H. Imran
Modified: 2023-05-14 13:51 UTC (History)
17 users (show)

See Also:
Latest Commit:
Version Fixed In: Spectacle 22.04 with kImageAnnotator 0.6.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nowshed H. Imran 2020-12-16 16:31:44 UTC
SUMMARY
Crop is an indispensable tool in a screenshot program. As spectacle has annotation now, the crop option will be great.



SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.20.4
KDE Frameworks Version: 5.77.0
Qt Version: 5.15.2
Kernel Version: 5.9.14-arch1-1
OS Type: 64-bit
Processors: 4 × Intel® Core™ i5-6200U CPU @ 2.30GHz
Memory: 3.7 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 520
Comment 1 Nate Graham 2020-12-16 21:20:16 UTC
Good idea!
Comment 2 Antonio Prcela 2021-02-09 22:15:20 UTC
*** Bug 428143 has been marked as a duplicate of this bug. ***
Comment 3 Patrick Silva 2021-06-05 10:34:06 UTC
*** Bug 438108 has been marked as a duplicate of this bug. ***
Comment 4 phrxmd 2021-08-30 09:17:20 UTC
Please, please add this.

I'm trying to work around this by using rectangular region, but it doesn't work as well, and you get side effects (like the application in question reacts to the mouse pointer and e.g. controls pop up in YouTube)
Comment 5 Kevin Colyer 2021-10-23 13:16:40 UTC
Just would like to add to this thread. I love spectacle and the annotation tools are a wonderful addition.

A crop tool would be an important addition. I needed it today. Mostly because I didn't think ahead to only snapshot a region. I am so lazy - but it would be a great addition to a wonderful tool.
Comment 6 Tony Murray 2021-11-22 13:16:43 UTC
A crop tool is also needed for my use case (cropping various screenshots for website development and training). Thank you!
Comment 7 Dan Dascalescu 2021-11-22 15:35:44 UTC
> A crop tool is also needed for my use case

What use case doesn't need a crop tool!? I'm befuddle as to how a screenshotting tool has annotations, but not cropping.
Comment 8 Nate Graham 2021-11-22 15:56:18 UTC
This is one of those cases where adding one feature changes people's expectations about other ones.

Spectacle never used to have *any* editing tools, so the lack of a crop tool was expected; you did your editing in another app. But when when we added annotation tools, suddenly people's expectations changed; now the expectation is that you do all of your screenshot editing within Spectacle, which makes the lack of a crop tool suddenly more annoying than it was before.

Probably the best place for this would be upstream in the annotation library we're using, so that Spectacle gets it for free.
Comment 9 Antonio Prcela 2021-11-27 16:13:32 UTC
Working upstream on it:
https://github.com/ksnip/kImageAnnotator/pull/263
Comment 10 Kevin Colyer 2021-11-27 17:08:26 UTC
Thanks so much! Very appreciated.
Comment 11 Bug Janitor Service 2021-12-01 12:46:09 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/spectacle/-/merge_requests/100
Comment 12 Tony Murray 2021-12-01 14:30:16 UTC
Thank you Antonio/ Nate et. al. - your work is very much appreciated!
Comment 13 Antonio Prcela 2021-12-05 18:04:57 UTC
Git commit 49b48a9aba30ba0644b2709e571a185b807e38e6 by Antonio Prcela.
Committed on 03/12/2021 at 16:16.
Pushed by ngraham into branch 'master'.

Enable newly introduced controls within kImageAnnotator

Adds undo, redo, crop, scale, rotate and modify canvas buttons.

Requires kImageAnnotator 0.6.0
Related: bug 429981

M  +1    -1    CMakeLists.txt
M  +1    -0    src/Gui/KSWidget.cpp

https://invent.kde.org/graphics/spectacle/commit/49b48a9aba30ba0644b2709e571a185b807e38e6
Comment 14 Ash 2022-05-04 00:18:52 UTC
It appears this feature was added to the kImageAnnotator library, but I still don't see a crop feature in Spectacle.
Is it not shipped yet, or is there some secret to enable it?
Comment 15 Prajna Sariputra 2022-05-04 00:50:16 UTC
As mentioned in comment 13 kImageAnnotator 0.6.0 is needed, however that hasn't been released yet.
Comment 16 Dan Dascalescu 2023-04-07 05:14:26 UTC
Almost a year later, I still don't see cropping in Spectacle :-/

Probably not surprising, as Help -> About shows v21.12.3, copyright 2015? I'm on Kubuntu 22.04, up to date.
Comment 17 Prajna Sariputra 2023-04-07 05:37:33 UTC
(In reply to Dan Dascalescu from comment #16)
> Almost a year later, I still don't see cropping in Spectacle :-/
> 
> Probably not surprising, as Help -> About shows v21.12.3, copyright 2015?
> I'm on Kubuntu 22.04, up to date.

As per the "Version Fixed In" field of the bug you need Spectacle 22.04 and kImageAnnotator 0.6.0.
Comment 18 Tony Murray 2023-04-07 10:01:14 UTC
(In reply to Dan Dascalescu from comment #16)
> Almost a year later, I still don't see cropping in Spectacle :-/
> 
> Probably not surprising, as Help -> About shows v21.12.3, copyright 2015?
> I'm on Kubuntu 22.04, up to date.

Additional information:
(In reply to Prajna Sariputra from comment #17)
> (In reply to Dan Dascalescu from comment #16)
> > Almost a year later, I still don't see cropping in Spectacle :-/
> > 
> > Probably not surprising, as Help -> About shows v21.12.3, copyright 2015?
> > I'm on Kubuntu 22.04, up to date.
> 
> As per the "Version Fixed In" field of the bug you need Spectacle 22.04 and
> kImageAnnotator 0.6.0.

(In reply to Prajna Sariputra from comment #17)
> (In reply to Dan Dascalescu from comment #16)
> > Almost a year later, I still don't see cropping in Spectacle :-/
> > 
> > Probably not surprising, as Help -> About shows v21.12.3, copyright 2015?
> > I'm on Kubuntu 22.04, up to date.
> 
> As per the "Version Fixed In" field of the bug you need Spectacle 22.04 and
> kImageAnnotator 0.6.0.

Additional information for Dan: (from personal investigation):
Kubuntu 22.10 (with backports repository) does have the kImageAnnotator with the cropping tool.

KDE Neon has the latest Spectacle version (currently 22.12.3), but it relies on Ubuntu LTS (22.04) which has kImageAnnotator 0.5.3  (/usr/lib/x86_64-linux-gnu/libkImageAnnotator.so.0.5.3)

The next Ubuntu LTS is due April 2024, and then Neon might be upgraded several months after that - October 2024, going by last time.
When using Neon, I instead export to Gwenview which has both crop and annotate operations. (you may need to customize toolbar/editing tools)

Hope this helps!
Comment 19 Störm Poorun 2023-05-14 13:38:17 UTC
Alas the cropping tool arrived, and has now disappeared again, due to a regression in 23.04 (?)

From 23.04 Spectacle appears to have stopped using kImageAnnotator (?) and the cropping tool has vanished 

Alas this is a significant regression for many users, and the tool is considered an essential and expected basic for any screenshot tool
Comment 20 Patrick Silva 2023-05-14 13:39:43 UTC
Regression already reported as bug 467590
Comment 21 Störm Poorun 2023-05-14 13:51:02 UTC
(In reply to Patrick Silva from comment #20)
> Regression already reported as bug 467590

Thanks for clarifying, have linked that bug as 'see also'