Bug 430418 - New sticky note no longer created when middle-clicking the desktop
Summary: New sticky note no longer created when middle-clicking the desktop
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Desktop Containment (show other bugs)
Version: 5.20.4
Platform: Neon Linux
: VHI normal
Target Milestone: 1.0
Assignee: Marco Martin
URL:
Keywords: regression
: 430420 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-12-15 12:04 UTC by proteus5
Modified: 2021-01-29 17:13 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21


Attachments
collision detected (342.14 KB, image/jpeg)
2020-12-18 18:30 UTC, proteus5
Details

Note You need to log in before you can comment on or make changes to this bug.
Description proteus5 2020-12-15 12:04:47 UTC
SUMMARY
Notes addon no longer works properly by clicking central mouse button

STEPS TO REPRODUCE
1. click by central button of the mouse in any desktop area;
2. no note appears
3. 

OBSERVED RESULT
no note appears


EXPECTED RESULT
a note appears

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.20
KDE Plasma Version: 5.20.4
KDE Frameworks Version: 5.77.0
Qt Version: 5.15.2
Kernel Version: 5.4.0-58-generic
OS Type: 64-bit
Comment 1 Nicolas Fella 2020-12-15 14:38:38 UTC
*** Bug 430420 has been marked as a duplicate of this bug. ***
Comment 2 Nate Graham 2020-12-17 18:24:11 UTC
Can confirm. My middle mouse button action is set to Paste, yet no note is created.
Comment 3 Nate Graham 2020-12-17 20:23:16 UTC
Why did you revert my changes to this bug report?
Comment 4 proteus5 2020-12-18 13:23:13 UTC
(In reply to Nate Graham from comment #3)
> Why did you revert my changes to this bug report?

Are you asking to me?
Comment 5 Nate Graham 2020-12-18 13:58:37 UTC
Yeah. :)
Comment 6 proteus5 2020-12-18 18:24:26 UTC
(In reply to Nate Graham from comment #5)
> Yeah. :)

I've just add an information in version field: 5.20.4 almost in the same time you were messaging. What happened after that I don't know.
Comment 7 Nate Graham 2020-12-18 18:26:02 UTC
Can confirm.
Comment 8 proteus5 2020-12-18 18:30:45 UTC
Created attachment 134189 [details]
collision detected

this is what happened
Comment 9 proteus5 2020-12-18 18:32:10 UTC
(In reply to Nate Graham from comment #7)
> Can confirm.

"I had just added an information in version field, that is 5.20.4, almost in the same time you were messaging. What happened after that I don't know.": regular form.
Comment 10 Nicolas Fella 2021-01-28 11:51:58 UTC
On a plain config Middle click paste is selected in the config but doesn't work for me. When I go to the settings, remove and readd the setting for it it starts to work
Comment 11 Nicolas Fella 2021-01-28 12:36:17 UTC
Found the culprit:

In https://invent.kde.org/plasma/plasma-desktop/-/blob/master/desktoppackage/contents/defaults#L8 MidButton needs to be changed to MiddleButton

This is a sideeffect of Qt changing Qt::MidButton to Qt::MiddleButton

This needs some special care to make sure existing configs are updated
Comment 13 Marco Martin 2021-01-29 16:00:33 UTC
Git commit e3bdb179817b75971bef0ca17e4feb5d25284241 by Marco Martin.
Committed on 29/01/2021 at 16:00.
Pushed by mart into branch 'master'.

migrate from MidButton to MiddleButton

the MidButton name first got deprecated, then doesn't really work anymore
this fixes middle button action on containments

M  +1    -1    desktoppackage/contents/defaults
A  +15   -0    desktoppackage/contents/updates/containmentactions_middlebutton.js

https://invent.kde.org/plasma/plasma-desktop/commit/e3bdb179817b75971bef0ca17e4feb5d25284241
Comment 14 Marco Martin 2021-01-29 16:01:35 UTC
Git commit beea5e694d35438be39f619999ea2a45f58f53f2 by Marco Martin.
Committed on 29/01/2021 at 16:01.
Pushed by mart into branch 'Plasma/5.21'.

migrate from MidButton to MiddleButton

the MidButton name first got deprecated, then doesn't really work anymore
this fixes middle button action on containments

M  +1    -1    desktoppackage/contents/defaults
A  +15   -0    desktoppackage/contents/updates/containmentactions_middlebutton.js

https://invent.kde.org/plasma/plasma-desktop/commit/beea5e694d35438be39f619999ea2a45f58f53f2