Bug 430265 - does not close accessed folder => accumulates folder tabs
Summary: does not close accessed folder => accumulates folder tabs
Status: RESOLVED INTENTIONAL
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 20.12.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2020-12-11 16:07 UTC by Philippe ROUBACH
Modified: 2020-12-30 15:29 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe ROUBACH 2020-12-11 16:07:49 UTC
SUMMARY


STEPS TO REPRODUCE
1. open dolphin and select a folder
2. close dolphin
3. open dolphin and select another folder
4. close dolphin and open dolphin

OBSERVED RESULT

dolphin displays 2 folder tabs corresponding to the 2 folders you selected

EXPECTED RESULT

dolphin displays only last accessed folder or the preselected folder 

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.20.4
KDE Frameworks Version: 5.76
Qt Version: 5.15.2


ADDITIONAL INFORMATION

kde app 20.12.0
Comment 1 Nate Graham 2020-12-16 22:26:30 UTC
This was an intentional change (see Bug 427274) but I'm starting to wonder if that was a good idea. To be honest, it kind of annoys me too--and I'm the one who made the change!

Thing is, we can't really revert this change without regressing the fix for Bug 427274.

Maybe it's something to make configurable, or maybe we need to make the tough decision of telling someone no. :)

In the meantime you can tell Dolphin to not remember any previous window state in its config window.
Comment 2 Philippe ROUBACH 2020-12-17 04:46:52 UTC
(In reply to Nate Graham from comment #1)

> In the meantime you can tell Dolphin to not remember any previous window
> state in its config window.

this is what i did.
Comment 3 Philippe ROUBACH 2020-12-17 04:50:05 UTC
add 2 options like in firefox "display last session" and "display history"
Comment 4 Nate Graham 2020-12-17 19:22:48 UTC
Elvis, what are your thoughts?
Comment 5 Elvis Angelaccio 2020-12-28 19:01:36 UTC
I think the fix for #427274 was necessary, you want tabs to be restored regardless of how you started dolphin.

I'm not sure how to reproduce this issue, the steps are not really clear.
Comment 6 Nate Graham 2020-12-28 19:47:06 UTC
> you want tabs to be restored regardless of how you started dolphin.
It would appear that the reporter of this bug report doesn't. :)

Here are clearer steps to reproduce:
1. Launch Dolphin and navigate somewhere, open some tabs, etc. Just use it normally
2. Close Dolphin
3. Launch Dolphin again with a specific location using an app's "Open Containing Folder" feature or by executing `dolphin [some location]`

Dolphin opens with the specified URL in a new tab, rather than erasing the history from the last session.
Comment 7 Elvis Angelaccio 2020-12-28 21:42:02 UTC
(In reply to Nate Graham from comment #6)
> > you want tabs to be restored regardless of how you started dolphin.
> It would appear that the reporter of this bug report doesn't. :)
> 
> Here are clearer steps to reproduce:
> 1. Launch Dolphin and navigate somewhere, open some tabs, etc. Just use it
> normally
> 2. Close Dolphin
> 3. Launch Dolphin again with a specific location using an app's "Open
> Containing Folder" feature or by executing `dolphin [some location]`
> 
> Dolphin opens with the specified URL in a new tab, rather than erasing the
> history from the last session.

Oh, I get it now. Yeah this is exactly what #427274 asked for...

But maybe a good middle-ground could be to revert that commit and change the label in the settings dialog to:

"Show on startup: Folders, tabs and window state from last time, if not asked for a specific folder". Or something similar :)
Comment 8 Nate Graham 2020-12-28 23:04:00 UTC
Or... make it configurable! >:P
Comment 9 Elvis Angelaccio 2020-12-29 21:47:40 UTC
A setting to configure another setting :D

After thinking more about this, I think we should close this ticket actually.
If you don't like tabs to be restored, you can just turn off the feature...
Comment 10 Nate Graham 2020-12-30 15:29:54 UTC
That seems reasonable to me. I imagine that the people who are annoyed by this behavior are satisfied by simply turning the feature off, as the reporter apparently has done.