Bug 430254 - popup palette doesn't work anymore
Summary: popup palette doesn't work anymore
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Color Selectors (show other bugs)
Version: 4.4.2-beta1
Platform: macOS (DMG) macOS
: NOR normal
Target Milestone: ---
Assignee: Tiar
URL:
Keywords: regression, release_blocker
: 430314 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-12-11 10:40 UTC by Manga Tengu
Modified: 2020-12-21 16:00 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.4.2-beta2
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Manga Tengu 2020-12-11 10:40:47 UTC
The popup advanced color selector displays correctly but clicking in it doesn't select colour and so does not make the selector disappear.
Comment 1 Ahab Greybeard 2020-12-11 10:55:54 UTC
I don't have this problem with the 4.4.2-beta2 appimage on Linux, Debian 10.
Comment 2 Manga Tengu 2020-12-11 11:49:50 UTC
This is really mac specific then I guess
Comment 3 Tiar 2020-12-11 12:44:05 UTC
By "anymore" I understand "it worked in 4.4.1"? Then I'm marking this as a regression.
Comment 4 Halla Rempt 2020-12-11 12:52:29 UTC
I can sort of reproduce on macOS, but it's more complicated than the original report says; also, it's about the shift-i color selector, not the popup palette.

* clicking doesn't select a color
* click-move does select a color
Comment 5 Halla Rempt 2020-12-11 12:54:56 UTC
And I can confirm it's a regression.
Comment 6 Tiar 2020-12-11 13:05:36 UTC
I can see the same behaviour in Krita 4.1.7 on my Linux, unless I misread something...

It seems deliberate/intentional - that way you can select both lightness and hue/color (depending on which selector you use, of course) at the same time (aka, without needing to click twice to get the selector). Moving away from the selector closes it.
Comment 7 Manga Tengu 2020-12-11 13:08:13 UTC
Oupsy yes that's the palette I meant. But it's very simple to reproduce in my case: I just launch krita and invoke this palette.
Comment 8 Halla Rempt 2020-12-11 13:12:23 UTC
I think the main problem on macos is that click doesn't select a color; not hiding the palette seems intentional.
Comment 9 Tiar 2020-12-15 01:03:12 UTC
Fixed in 5a4fe7ee2084ef26ddafc28e7e864b598e16e22c, backported to f5c98f5d93110444f6a63496d58f8e04eda0f01b.

---
https://invent.kde.org/graphics/krita/-/commit/5a4fe7ee2084ef26ddafc28e7e864b598e16e22c

Fix triangle color selector not reacting to mouse events

Before this commit, there was an issue with selecting the colors from
the left and top areas. It was possible to move to them only if the user
dragged the point from the right-bottom area. This was a regression
from ae1b3c71.

This commit fixes this behaviour by making sure that the "constainsPoint"
method returns true for all the appropriate points even on high dpi
displays.
Comment 10 Tiar 2020-12-21 16:00:11 UTC
*** Bug 430314 has been marked as a duplicate of this bug. ***