Bug 430244 - Fill layer with pattern and cloned layer display anomalous pattern
Summary: Fill layer with pattern and cloned layer display anomalous pattern
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: layer styles (show other bugs)
Version: 4.4.2-beta1
Platform: unspecified macOS
: NOR normal
Target Milestone: ---
Assignee: amyspark
URL:
Keywords: regression, release_blocker
Depends on:
Blocks:
 
Reported: 2020-12-11 03:08 UTC by chrispbolduc
Modified: 2020-12-15 20:50 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
link to file that displays issue (82 bytes, text/plain)
2020-12-11 03:08 UTC, chrispbolduc
Details

Note You need to log in before you can comment on or make changes to this bug.
Description chrispbolduc 2020-12-11 03:08:43 UTC
Created attachment 133987 [details]
link to file that displays issue

SUMMARY
When I open file(made on 4.4.1) in the 4.4.2 beta, a fill layer with rough paper pattern and cloned layer, both display a grid pattern that was not part of the original file.


STEPS TO REPRODUCE
1. open file
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Tiar 2020-12-11 03:11:12 UTC
Thanks for the report!
Comment 2 Dmitry Kazakov 2020-12-15 19:36:25 UTC
The link to the original post with more screenshots:
https://krita-artists.org/t/first-beta-of-krita-4-4-2-help-in-testing-needed/15369/12?u=dkazakov
Comment 3 Dmitry Kazakov 2020-12-15 20:46:11 UTC
Git commit 6adc6bfbb180bcb0b7bff172452ef9ba256a2e8e by Dmitry Kazakov.
Committed on 15/12/2020 at 20:45.
Pushed by dkazakov into branch 'krita/4.3'.

Fix loading generator layers

When loading generator layers we write directly into its internal
filter, because KisFilterConfigutration does not have copying API.

We used a hack for assigning this filter again, but it stopped
working after generator layers got the ability to compare equality
of the filter configurations.
Related: bug 430246

M  +1    -1    plugins/impex/libkra/kis_kra_load_visitor.cpp

https://invent.kde.org/graphics/krita/commit/6adc6bfbb180bcb0b7bff172452ef9ba256a2e8e
Comment 4 Dmitry Kazakov 2020-12-15 20:46:48 UTC
Git commit aa86f66b0b0b9cd2d0a1fca0bda1ca6928462ccb by Dmitry Kazakov.
Committed on 15/12/2020 at 20:46.
Pushed by dkazakov into branch 'krita/4.4.2'.

Fix loading generator layers

When loading generator layers we write directly into its internal
filter, because KisFilterConfigutration does not have copying API.

We used a hack for assigning this filter again, but it stopped
working after generator layers got the ability to compare equality
of the filter configurations.
Related: bug 430246

M  +1    -1    plugins/impex/libkra/kis_kra_load_visitor.cpp

https://invent.kde.org/graphics/krita/commit/aa86f66b0b0b9cd2d0a1fca0bda1ca6928462ccb
Comment 5 Dmitry Kazakov 2020-12-15 20:50:32 UTC
The bug is fixed in krita/4.3 and krita/4.4.2 branches. It should not be present in master branch, because that code has been refactored out during the resource rewrite.