Bug 430204 - User details shows "create new user" page instead of the one for the correct user
Summary: User details shows "create new user" page instead of the one for the correct ...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_users (show other bugs)
Version: unspecified
Platform: Other Linux
: VHI normal
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-12-10 03:59 UTC by Nate Graham
Modified: 2020-12-10 20:45 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Wrong page shown (412.46 KB, image/jpeg)
2020-12-10 03:59 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2020-12-10 03:59:07 UTC
Created attachment 133960 [details]
Wrong page shown

Regression on git master. Bisect coming soon.

Right now clicking on any of the users in the users KCM takes me to the "create new user" page, rather than the page for that user.
Comment 1 Nate Graham 2020-12-10 04:01:44 UTC
Git bisect says it was ed75689957b48a28faa037e0ccbc92fe9256e727.
Comment 2 Nate Graham 2020-12-10 04:13:59 UTC
Forgot to mention, but this is the console output:



file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:48:5: QML Connections: Detected function "onPasswordSuccessfullyChanged" in Connections element. This is probably intended to be a signal handler but no signal of the target matches the name.
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:40:5: QML Connections: Detected function "onApplyError" in Connections element. This is probably intended to be a signal handler but no signal of the target matches the name.
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:34:5: Unable to assign [undefined] to QString
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:133:21: Unable to assign [undefined] to QString
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:132:21: Unable to assign [undefined] to QUrl
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:154:17: Unable to assign [undefined] to QString
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:162:17: Unable to assign [undefined] to QString
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:183:17: Unable to assign [undefined] to QString
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:75: Error: Cannot assign [undefined] to QString
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:302: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:203: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:183: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:177: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:162: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:132: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:133: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:34: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:416: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:416: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:416: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:416: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:416: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:416: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:416: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:416: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:416: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:416: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:416: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:416: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:416: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:416: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:416: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:416: TypeError: Value is null and could not be converted to an object
file:///home/nate/kde/usr/share/kpackage/kcms/kcm_users/contents/ui/UserDetailsPage.qml:89: TypeError: Value is null and could not be converted to an object
Comment 3 Bug Janitor Service 2020-12-10 20:14:48 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/259
Comment 4 Janet Blackquill 2020-12-10 20:45:51 UTC
Git commit b754fafdcf6322527a2cf23354caa2e2c6c04472 by Carson Black.
Committed on 10/12/2020 at 20:44.
Pushed by ngraham into branch 'master'.

Fix users KCM navigating to pages with null users

This was caused by us registering the User as a type, which conflicted with the model role also named User.

M  +1    -1    kcms/users/package/contents/ui/main.qml
M  +1    -1    kcms/users/src/usermodel.cpp

https://invent.kde.org/plasma/plasma-desktop/commit/b754fafdcf6322527a2cf23354caa2e2c6c04472