Bug 430196 - Option to use "liked" / "favorite" style ratings instead of stars
Summary: Option to use "liked" / "favorite" style ratings instead of stars
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-09 21:29 UTC by Nate Graham
Modified: 2021-10-08 15:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 21.12


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2020-12-09 21:29:22 UTC
Elisa's ratings right now support the style where you assign a number of stars to a song.

Personally I find that I only ever assign a rating of 5 stars to my favorite songs; I don't care to be granular enough to rate literally every song and give some of the songs 4 start, 2 stars, etc.

Accordingly, I feel like it would be nice if Elisa offered to switch to a heart/thumbsup/favorite rating scheme where you would mark songs as "liked" or "favorite" or whatever instead of assigning stars. Behind the scenes, perhaps it could simply set a rating of 5 stars for these songs, and display 5-star-rated songs with the "liked" or "favorite" icon or whatever.
Comment 1 Bug Janitor Service 2021-08-18 17:41:06 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/276
Comment 2 Nate Graham 2021-10-08 15:42:13 UTC
Git commit 6089288a629cfdf566b499224a403744efe3ff61 by Nate Graham.
Committed on 08/10/2021 at 15:41.
Pushed by ngraham into branch 'master'.

Optional "favorite" style ratings

This commit adds an optional and off-by-default mode to display ratings
as "favorite"/"not favorite" rather than zero to five stars. This
supports people whose rating habits lead them to rate certain songs
with five stars but never use the 1, 2, 3, or 4 star ratings. In this
style, you're basically using the rating system to mark your favorite
songs rather than really rating them. This new mode makes that a bit
more natural for people who prefer that style.

In terms of implementation, when using this mode, songs with 5 stars are
considered to be "favorite" songs, and songs with any other rating are
considered to be "not favorite". Marking a song as a favorite internally
sets it to 5 stars, and it will appear as a 5-star song in other apps.

Note that I have used the existing star-style "rating" and
"rating-unrated" icons for this mode due to the absence of an adequate
pair of filled/unfilled heart icons in the Breeze icon theme. If those
are later added, it could be switched over to use them.
FIXED-IN: 21.12

M  +6    -1    src/elisa_core.kcfg
M  +7    -0    src/elisaapplication.cpp
M  +8    -0    src/elisaapplication.h
M  +15   -0    src/localFileConfiguration/elisaconfigurationdialog.cpp
M  +16   -0    src/localFileConfiguration/elisaconfigurationdialog.h
M  +50   -1    src/qml/ListBrowserDelegate.qml
M  +41   -11   src/qml/MediaTrackMetadataDelegate.qml
M  +18   -3    src/qml/NavigationActionBar.qml
M  +37   -2    src/qml/PlayListEntry.qml
M  +29   -0    src/qml/SettingsForm.qml

https://invent.kde.org/multimedia/elisa/commit/6089288a629cfdf566b499224a403744efe3ff61