SUMMARY I added a location (address) information and forgot to hit the [Add Address] button before clicking OK :-( The edit contact window closed and I had to add all the information again. Please check if there were any changes in the dialog and prompt for confirmation. STEPS TO REPRODUCE 1. use an exiting contact without an address 2. add an address but do NOT hit [Add Address] button 3. click OK OBSERVED RESULT The new address information is gone/ignored/not stored EXPECTED RESULT A message prompt: "Address information not added - are you sure?" with buttons OK and Cancel. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: openSUSE Leap 15.2 (available in About System) KDE Plasma Version: 5.18.5 KDE Frameworks Version: 5.71.0 Qt Version: 5.12.7 ADDITIONAL INFORMATION
Hello, I don't understand could you create a screenshot about dialogbox please ? if you don't add email but clicked on ok it will save other settings no ?
Created attachment 133932 [details] Screenshot of Edit Contact - Location/Address When hitting OK without hitting [Add Address] before, all entered input is lost. Better let the user have a chance to add address before closing the dialog.
Ah ok I understand. No problem I will work on it soon
Git commit 5bd2d4d3c778047b4690eb3970a3f16098500a46 by Laurent Montel. Committed on 09/12/2020 at 07:56. Pushed by mlaurent into branch 'release/20.12'. Start to fix 430119 M +7 -0 src/contact-editor/editor/addresseditor/addresslocationwidget.cpp M +3 -1 src/contact-editor/editor/addresseditor/addresslocationwidget.h https://invent.kde.org/pim/akonadi-contacts/commit/5bd2d4d3c778047b4690eb3970a3f16098500a46
Git commit ca8ef1ce945f31a2f11f32b2ea91dc5fabc03425 by Laurent Montel. Committed on 16/12/2020 at 06:34. Pushed by mlaurent into branch 'release/20.12'. Fix Bug 430119 - Confirm add address on OK FIXED-IN: 5.15.1 M +5 -0 src/akonadi-contacts/contacteditor.cpp M +1 -0 src/akonadi-contacts/contacteditor.h M +13 -5 src/akonadi-contacts/contacteditordialog.cpp M +2 -0 src/contact-editor/abstractcontacteditorwidget_p.h M +5 -0 src/contact-editor/editor/addresseditor/addresseslocationwidget.cpp M +2 -1 src/contact-editor/editor/addresseditor/addresseslocationwidget.h M +1 -1 src/contact-editor/editor/addresseditor/addresslocationwidget.h M +5 -0 src/contact-editor/editor/contacteditorwidget.cpp M +1 -0 src/contact-editor/editor/contacteditorwidget.h https://invent.kde.org/pim/akonadi-contacts/commit/ca8ef1ce945f31a2f11f32b2ea91dc5fabc03425