Bug 430048 - "Start a Slideshow with selected image" Dolphin context menu plugin should only appear when more than one image is selected
Summary: "Start a Slideshow with selected image" Dolphin context menu plugin should on...
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-05 17:26 UTC by Nate Graham
Modified: 2021-02-02 20:32 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/graphics/gwenview/commit/a6ceabe9e355581c89b28625ae59a6d7b112bea4
Version Fixed In: 21.04

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2020-12-05 17:26:36 UTC 
As the menu title suggests, this action doesn't make much sense when only a single image is selected. It just clutters up the context menu. We should consider only showing it when 2 or more images are selected.
Comment 1 Méven Car 2020-12-07 07:12:41 UTC 
Fix proposal at https://invent.kde.org/graphics/gwenview/-/merge_requests/24
Comment 2 Méven Car 2021-02-02 20:32:44 UTC 
Git commit a6ceabe9e355581c89b28625ae59a6d7b112bea4 by Méven Car.
Committed on 02/02/2021 at 20:32.
Pushed by meven into branch 'master'.

Replace slideshow ServiceMenu by SlideShowFileItemAction

Using a KAbstractFileItemActionPlugin allows to have more control over when actions are shown in context menus.
Related: bug 429531
FIXED-IN: 21.04

M  +12   -2    app/CMakeLists.txt
D  +0    -70   app/slideshow.desktop
A  +90   -0    app/slideshowfileitemaction.cpp     [License: GPL]
A  +45   -0    app/slideshowfileitemaction.h     [License: GPL]
A  +15   -0    app/slideshowfileitemaction.json

https://invent.kde.org/graphics/gwenview/commit/a6ceabe9e355581c89b28625ae59a6d7b112bea4