SUMMARY In the "enter file name" for new file / folder dialog, the OK button flickers between enabled and disabled and when rapidly typing a file name and hitting reutnr, nothing happens. STEPS TO REPRODUCE 1. Press F10 in Dolphin 2. Type a new file name and immediately press return 3. OBSERVED RESULT Nothing happens EXPECTED RESULT Folder with entered name is created SOFTWARE/OS VERSIONS KDE Plasma Version: 5.20.80 KDE Frameworks Version: 5.76 Qt Version: 5.15.1 ADDITIONAL INFORMATION Probably caused by disabling the button in KNewFileMenuPrivate::_k_slotTextChanged and then doing a StatJob to find whether the folder exists which then asynchronously sets the button back enabled when finished.
Confirmed. Kind of annoying.
This is a behavior change that appeared with https://invent.kde.org/frameworks/kio/commit/183086f54e447b95370e0244740e315f1f5d4e8e The fixed delay of 150ms should probably be adjusted, for instance adapting to the typing speed of the user to avoid flickering, and we probably would need to "cache" a return key to apply the Enter as soon as the stat finishes and validates the dest file does not exist. This issue concerns mainly fast typist and at worst they need to wait for 150ms before being allowed to "return".
Well the issue is that the button flickering is unsightly. If there's a timer blocking things, the button should always be clickable, and it should just delay actually completing its action until the timer fires.
I tested changing the delay from 150ms to 350ms, less flickering.
But that would make it even worse! :) You'd hit the return key after typing and it would do nothing.
> Well the issue is that the button flickering is unsightly. If there's a timer blocking things, the button should always be clickable, and it should just delay actually completing its action until the timer fires. I had trouble initially trying to do that. This is doable simply using eventFilters I believe, should have thought of it earlier.
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/242
*** Bug 430027 has been marked as a duplicate of this bug. ***
Git commit 67a4643c97486ff574bfcb80a0a31c9c97980ba1 by David Faure, on behalf of Méven Car. Committed on 05/12/2020 at 10:42. Pushed by dfaure into branch 'master'. NewFile Dialog: allow to accept directory creation before stat has run Cache the fact the user tried to accept the dialog and apply it when checks and stat have been run. FIXED-IN: 5.77 M +34 -4 src/filewidgets/knewfilemenu.cpp https://invent.kde.org/frameworks/kio/commit/67a4643c97486ff574bfcb80a0a31c9c97980ba1