Bug 429820 - Checkboxes should be radio buttons in Tags Matching Condition "OR/AND" chooser
Summary: Checkboxes should be radio buttons in Tags Matching Condition "OR/AND" chooser
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Menus (show other bugs)
Version: 7.2.0
Platform: Appimage Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-29 18:30 UTC by Mike Morrison
Modified: 2020-11-29 21:24 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/graphics/digikam/commit/7bd026ca431cb5ec3619fa5ae84086c1017a611d
Version Fixed In: 7.2.0
Sentry Crash Report:

Attachments
Screenshot of current interface (2.73 KB, image/png)
2020-11-29 18:30 UTC, Mike Morrison 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Morrison 2020-11-29 18:30:39 UTC 
Created attachment 133734 [details]
Screenshot of current interface

It seems the "OR" and "AND" options are mutually exclusive in the "Tags Matching Condition" pop-up menu when filtering tags. Perhaps they should be radio buttons, rather than checkboxes.

SOFTWARE/OS VERSIONS
Ubuntu 20.10
digikam-7.2.0-beta2-20201120T061443-x86-64.appimage 
KDE Frameworks Version: 5.74.0
Qt Version: 5.14.2
Comment 1 Maik Qualmann 2020-11-29 19:57:11 UTC 
A check box would be out of place here, there is no multiple selection.

Maik
Comment 2 Mike Morrison 2020-11-29 20:04:11 UTC 
I agree. Currently they are displayed as checkboxes, as shown in the attached screenshot. Radio buttons would be better.
Comment 3 Maik Qualmann 2020-11-29 21:24:57 UTC 
Git commit 7bd026ca431cb5ec3619fa5ae84086c1017a611d by Maik Qualmann.
Committed on 29/11/2020 at 21:24.
Pushed by mqualmann into branch 'master'.

use QActionGroup to display radio buttons
FIXED-IN: 7.2.0

M  +2    -1    NEWS
M  +5    -1    core/app/filters/filtersidebarwidget.cpp

https://invent.kde.org/graphics/digikam/commit/7bd026ca431cb5ec3619fa5ae84086c1017a611d