Bug 429797 - Tiny scrollviews in various applet config windows
Summary: Tiny scrollviews in various applet config windows
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (other bugs)
Version First Reported In: master
Platform: Neon Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-11-29 10:18 UTC by Patrick Silva
Modified: 2020-12-02 22:39 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
screenshot (34.46 KB, image/png)
2020-11-29 10:18 UTC, Patrick Silva
Details
Holidays section of Digital Clock settings (91.42 KB, image/png)
2020-11-29 10:54 UTC, Patrick Silva
Details
screen recording (2.56 MB, video/webm)
2020-12-01 04:12 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-11-29 10:18:21 UTC
Created attachment 133720 [details]
screenshot

Title says it all. See the attached screenshot please.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.77.0
Qt Version: 5.15.1
Comment 1 Patrick Silva 2020-11-29 10:54:44 UTC
Created attachment 133723 [details]
Holidays section of Digital Clock settings

I'm not sure if this is related, but the scrollable area is small in Holidays
section of Digital Clock settings.
Comment 2 Nate Graham 2020-11-30 22:19:22 UTC
How did you get in this state? It's working fine for me. A screen recording would be helpful.
Comment 3 Patrick Silva 2020-12-01 04:12:27 UTC
Created attachment 133764 [details]
screen recording
Comment 4 Nate Graham 2020-12-01 16:20:48 UTC
What the heck.

Since this affects the settings windows of multiple applets, I suspect that it's is caused by a regression in the applet config window itself, when displayed on a short screen. What's the resolution of your screen?
Comment 5 Nicolas Fella 2020-12-01 16:22:15 UTC
I'm waaaaay ahead of you :P
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/244
Comment 6 Nicolas Fella 2020-12-02 22:39:18 UTC
Git commit 56513036410f547e21adddb1465f49dbffed73ae by Nicolas Fella.
Committed on 02/12/2020 at 22:36.
Pushed by nicolasfella into branch 'master'.

[plasmoidconfig] Fix sizing for some configurations

We'd like to rely on the config to give us an appropriate
implicitHeight, but some configs do the opposite and assume they fill
the parent. The old code resolved this by making the config at least as
high as its parent. Reintroduce that.

This is arguably all very ugly and should be resolved properly, but that
requires changing the configs themselves, which is infeasible for Plasma
5 with regards to third-party applets

M  +7    -3    desktoppackage/contents/configuration/ConfigurationAppletPage.qml

https://invent.kde.org/plasma/plasma-desktop/commit/56513036410f547e21adddb1465f49dbffed73ae