Bug 429792 - Face tag name completion with arrow keys fails
Summary: Face tag name completion with arrow keys fails
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Faces-Workflow (show other bugs)
Version: 7.2.0
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-29 05:57 UTC by Mike Morrison
Modified: 2021-01-16 20:40 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.2.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Morrison 2020-11-29 05:57:22 UTC
SUMMARY
Sometimes, when adding a face tag, if the user types a few letters and uses the keyboard arrow keys to choose from the suggested names, the complete name fails to populate the tag. Only the few letters typed are used.

STEPS TO REPRODUCE
1. In Albums view, click on a photo to select it.
2. Press F3 to preview the photo.
3. Click the "Add a Face Tag" button, and then drag to draw a rectangle on the photo.
4. Notice that "Unknown" is selected in blue in the new tag's text box. Without clicking anything, type a few letters of a name, for example "mi".
5. A drop-down list of existing People tag names appears, showing names that contain the case-insensitive substring "mi". Press the down-arrow key several times, and notice the blue selection moving down the list of names. 

OBSERVED RESULT
Despite the selection of completed names in the dropdown, the text field above the dropdown still shows only "mi". If the user presses "Enter" at this time, a new People tag called "mi" will be created and assigned to the photo. This behavior is somewhat intermittent, but I can reproduce it via the exact steps above.

EXPECTED RESULT
As the down-arrow key moves the selection down the list of names, the selected name should appear in the text box at the top. When "Enter" is pressed, the selected name should be assigned to the photo. No new tag names should be created unless the user moves the selection all the way down to 'Create "mi" in People'.

SOFTWARE/OS VERSIONS
Ubuntu 20.10
digiKam 7.2.0-beta1, build date Oct 17 2020
KDE Frameworks Version: 5.74.0
Qt Version: 5.14.2
Comment 1 Maik Qualmann 2020-11-29 09:07:25 UTC
That is strange. In digiKam-7.2.0-Beta2 the signal/slot connection from the QCompleter does not always work.

Maik
Comment 2 Maik Qualmann 2020-12-21 17:17:35 UTC
*** Bug 430671 has been marked as a duplicate of this bug. ***
Comment 3 Maik Qualmann 2021-01-05 18:47:38 UTC
*** Bug 431188 has been marked as a duplicate of this bug. ***
Comment 4 Maik Qualmann 2021-01-09 16:04:20 UTC
*** Bug 431357 has been marked as a duplicate of this bug. ***
Comment 5 Maik Qualmann 2021-01-09 18:12:03 UTC
Git commit 86ce760d9b623a6ce2ea8f1b4eb49abd910ca6fb by Maik Qualmann.
Committed on 09/01/2021 at 18:10.
Pushed by mqualmann into branch 'master'.

workaround for the overlay popup that lost updating the text edit
Related: bug 430671, bug 431188, bug 431357
FIXED-IN: 7.2.0

M  +7    -0    core/libs/tags/widgets/addtagscombobox.cpp

https://invent.kde.org/graphics/digikam/commit/86ce760d9b623a6ce2ea8f1b4eb49abd910ca6fb
Comment 6 Mike Morrison 2021-01-16 20:40:09 UTC
Thank you for fixing this! It makes the workflow so much easier now.