Bug 429787 - Delete Unassigned Tags: show list of the unassigned tags before deleting them
Summary: Delete Unassigned Tags: show list of the unassigned tags before deleting them
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Tags-Manager (show other bugs)
Version: 7.2.0
Platform: Appimage Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-29 01:50 UTC by Mike Morrison
Modified: 2020-11-29 07:07 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.2.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Morrison 2020-11-29 01:50:15 UTC
In the Tags Manager, when the user chooses "Delete Unassigned Tags", it would be nice if digiKam displayed a list of the names of the unassigned tags when asking for confirmation.

Currently there is a Warning dialog which says "This option will remove all tags which are not assigned to any image. Do you want to continue?"

It would be nice if this warning dialog included a list of the tags which will be deleted, in case the user wants to cancel the deletion, for example if some of the tags are placeholders which the user was intending to start using.

Alternatively, the list could appear after deletion, showing the names of the tags that were deleted. Currently only the total number of such tags is displayed ("n unused tags were removed.")

SOFTWARE/OS VERSIONS
Ubuntu 20.10
digikam-7.2.0-beta2-20201120T061443-x86-64.appimage 
KDE Frameworks Version: 5.74.0
Qt Version: 5.14.2
Comment 1 Maik Qualmann 2020-11-29 06:58:15 UTC
Git commit a3aed91dda2fd9033272b89aefa89e9fa9a3de86 by Maik Qualmann.
Committed on 29/11/2020 at 06:57.
Pushed by mqualmann into branch 'master'.

only mark all tags that are not assigned to images
FIXED-IN: 7.2.0

M  +2    -1    NEWS
M  +17   -50   core/libs/tags/manager/tagsmanager.cpp
M  +2    -2    core/libs/tags/manager/tagsmanager.h

https://invent.kde.org/graphics/digikam/commit/a3aed91dda2fd9033272b89aefa89e9fa9a3de86
Comment 2 Maik Qualmann 2020-11-29 07:03:38 UTC
Displaying all tags, especially if there are a lot of them, makes no sense. The function now marks all tags that are unused. You can then are still unselect tags and then remove them with the delete tags function.

Maik
Comment 3 Mike Morrison 2020-11-29 07:07:37 UTC
That's a perfect solution. Thanks!