Bug 429762 - cannot paste files/folders via context menu
Summary: cannot paste files/folders via context menu
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: VHI normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-11-28 14:55 UTC by Patrick Silva
Modified: 2020-11-30 23:10 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-11-28 14:55:07 UTC
SUMMARY
Reproducible on neon unstable and with Dolphin 20.12 RC on Arch Linux.

STEPS TO REPRODUCE
1. copy any file/folder
2. try to paste the copied file/folder into another folder via context menu
3. 

OBSERVED RESULT
nothing happens. ctrl+v shortcut pastes the copied file/folder as expected 

EXPECTED RESULT


SOFTWARE/OS VERSIONS 
Linux/KDE Plasma: Arch Linux
KDE Plasma Version: 5.20.3
KDE Frameworks Version: 5.76.0
Qt Version: 5.15.2
Comment 1 Christoph Feck 2020-11-28 16:08:58 UTC
Confirmed on K:U:F
Comment 2 Nate Graham 2020-11-28 16:34:45 UTC
Yikes.
Comment 3 Nate Graham 2020-11-28 16:43:43 UTC
Git bisect pins the blames on the following:


commit 5c99790c945c827d45ce8bd9e1b7acd6657e6be3
Author: Méven Car <meven29@gmail.com>
Date:   Sat Nov 14 07:58:24 2020 +0100

    Context Menu: Only add paste action to folders
    
    Either the viewport, or the selected folder is used as destination.
    The paste action is only added when enabled.

 src/dolphincontextmenu.cpp | 53 +++++++++++++++++++++++++++++-----------------
 1 file changed, 34 insertions(+), 19 deletions(-)



Unfortunately this commit is in the 5.12 branch and will be a significant regression should it ship to users. I would recommend fixing ASAP and doing an emergency re-spin of the tar.

Méven, can you take a look?
Comment 4 Bug Janitor Service 2020-11-30 08:02:03 UTC
A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/129
Comment 5 Méven Car 2020-11-30 23:10:45 UTC
Git commit c2a7bde383e4ffab6f4397bcfc7d3896adab877f by Méven Car.
Committed on 30/11/2020 at 21:18.
Pushed by elvisangelaccio into branch 'release/20.12'.

Re-allow to paste files via context menu

M  +9    -9    src/dolphincontextmenu.cpp

https://invent.kde.org/system/dolphin/commit/c2a7bde383e4ffab6f4397bcfc7d3896adab877f