Bug 429686 - KisKraSaverTest crashes on testRoundtripStoryBoard
Summary: KisKraSaverTest crashes on testRoundtripStoryBoard
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Storyboard (show other bugs)
Version: 4.3.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Eoin O'Neill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-26 12:05 UTC by Halla Rempt
Modified: 2021-01-07 10:21 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Halla Rempt 2020-11-26 12:05:05 UTC 
This is the backtrace:

[Switching to Thread 0x7fffdebfc700 (LWP 372952)]
0x00007ffff3d3d384 in QVariant::QVariant(QVariant const&) () from /lib/x86_64-linux-gnu/libQt5Core.so.5
(gdb) bt
#0  0x00007ffff3d3d384 in QVariant::QVariant(QVariant const&) () from /lib/x86_64-linux-gnu/libQt5Core.so.5
#1  0x00007ffff70a3104 in StoryboardChild::data (this=<optimized out>) at /home/boud/dev/krita/libs/ui/StoryboardItem.h:141
#2  StoryboardItem::toXML (this=this@entry=0x555556b72940, doc=...) at /home/boud/dev/krita/libs/ui/StoryboardItem.cpp:89
#3  0x00007fffe40fb52f in KisKraSaver::saveStoryboardToXML (this=<optimized out>, doc=..., element=...) at /home/boud/dev/krita/plugins/impex/libkra/kis_kra_saver.cpp:250
#4  0x00007fffe40fb915 in KisKraSaver::saveStoryboard (this=this@entry=0x7fffc406d310, store=0x7fffc4005240, image=..., uri=...) at /home/boud/dev/krita/plugins/impex/libkra/kis_kra_saver.cpp:207
#5  0x00007fffe413e077 in KraConverter::buildFile (this=0x7fffdebfb970, io=<optimized out>, filename=...) at /usr/include/c++/9/bits/atomic_base.h:318
#6  0x00007fffe4135ff9 in KraExport::convert (this=0x555556c6d610, document=<optimized out>, io=0x7fffdebfba60) at /home/boud/dev/krita/plugins/impex/kra/kra_export.cpp:62
#7  0x00007ffff6ffd629 in KisImportExportManager::doExportImpl (this=0x555556d0b390, location=..., filter=..., exportConfiguration=...) at /usr/include/c++/9/bits/atomic_base.h:318
#8  0x00007ffff6ffd9a4 in KisImportExportManager::doExport (this=0x555556d0b390, location=..., filter=..., exportConfiguration=..., alsoAsKra=<optimized out>) at /usr/include/c++/9/bits/atomic_base.h:318
#9  0x00007ffff700117d in std::__invoke_impl<KisImportExportErrorCode, KisImportExportErrorCode (KisImportExportManager::*&)(QString const&, QSharedPointer<KisImportExportFilter>, KisPinnedSharedPtr<KisPropertiesConfiguration>, bool), KisImportExportManager*&, QString&, QSharedPointer<KisImportExportFilter>&, KisPinnedSharedPtr<KisPropertiesConfiguration>&, bool&> (__t=<optimized out>, __f=<optimized out>) at /usr/include/c++/9/bits/atomic_base.h:318
#10 std::__invoke<KisImportExportErrorCode (KisImportExportManager::*&)(QString const&, QSharedPointer<KisImportExportFilter>, KisPinnedSharedPtr<KisPropertiesConfiguration>, bool), KisImportExportManager*&, QString&, QSharedPointer<KisImportExportFilter>&, KisPinnedSharedPtr<KisPropertiesConfiguration>&, bool&> (__fn=<optimized out>) at /usr/include/c++/9/bits/invoke.h:96
#11 std::_Bind<KisImportExportErrorCode (KisImportExportManager::*(KisImportExportManager*, QString, QSharedPointer<KisImportExportFilter>, KisPinnedSharedPtr<KisPropertiesConfiguration>, bool))(QString const&, QSharedPointer<KisImportExportFilter>, KisPinnedSharedPtr<KisPropertiesConfiguration>, bool)>::__call<KisImportExportErrorCode, , 0ul, 1ul, 2ul, 3ul, 4ul>(std::tuple<>&&, std::_Index_tuple<0ul, 1ul, 2ul, 3ul, 4ul>) (__args=..., 
    this=<optimized out>) at /usr/include/c++/9/functional:402
#12 std::_Bind<KisImportExportErrorCode (KisImportExportManager::*(KisImportExportManager*, QString, QSharedPointer<KisImportExportFilter>, KisPinnedSharedPtr<KisPropertiesConfiguration>, bool))(QString const&, QSharedPointer<KisImportExportFilter>, KisPinnedSharedPtr<KisPropertiesConfiguration>, bool)>::operator()<, KisImportExportErrorCode>() (this=<optimized out>) at /usr/include/c++/9/functional:484
#13 std::_Function_handler<KisImportExportErrorCode (), std::_Bind<KisImportExportErrorCode (KisImportExportManager::*(KisImportExportManager*, QString, QSharedPointer<KisImportExportFilter>, KisPinnedSharedPtr<KisPropertiesConfiguration>, bool))(QString const&, QSharedPointer<KisImportExportFilter>, KisPinnedSharedPtr<KisPropertiesConfiguration>, bool)> >::_M_invoke(std::_Any_data const&) (__functor=...) at /usr/include/c++/9/bits/std_function.h:286
#14 0x00007ffff7003c1d in std::function<KisImportExportErrorCode ()>::operator()() const (this=0x555556a602d8) at /usr/include/c++/9/bits/std_function.h:683
#15 QtConcurrent::StoredFunctorCall0<KisImportExportErrorCode, std::function<KisImportExportErrorCode ()> >::runFunctor() (this=0x555556a60290) at /usr/include/x86_64-linux-gnu/qt5/QtConcurrent/qtconcurrentstoredfunctioncall.h:60
#16 0x00007ffff7001715 in QtConcurrent::RunFunctionTask<KisImportExportErrorCode>::run (this=0x555556a60290) at /home/boud/dev/krita/libs/global/kis_shared_ptr.h:203
#17 0x00007ffff3b18f22 in ?? () from /lib/x86_64-linux-gnu/libQt5Core.so.5
#18 0x00007ffff3b15b1c in ?? () from /lib/x86_64-linux-gnu/libQt5Core.so.5
#19 0x00007ffff363e609 in start_thread (arg=<optimized out>) at pthread_create.c:477
#20 0x00007ffff377a293 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
Comment 1 Eoin O'Neill 2021-01-07 03:32:55 UTC 
Is this still occurring on your end, Halla? 

I swear I checked before break and it was crashing, but coming back to this today I found that I'm passing the test. Perhaps somebody corrected the issue before me?
Comment 2 Halla Rempt 2021-01-07 10:21:53 UTC 
I think Dmitry fixed it:

commit 338f90ee18dd6c4d4ad3c1722fdd6b30b9e42a98
Author: Dmitry Kazakov <dimula73@gmail.com>
Date:   Fri Dec 4 14:52:26 2020 +0300

    Fix KisKraSaverTest

    We should make the process of initialization for
    StoryboardItem more fool-proof. Now it just crashes
    with invalid memory access when some of its fields are
    not properly initialized.