SUMMARY STEPS TO REPRODUCE 1. Launch Knights 2. Play 3. Hear the voice OBSERVED RESULT Voice is always on. EXPECTED RESULT Any player should be able to disable it. SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: Kubuntu 20.10 (available in About System) KDE Plasma Version: KDE Frameworks Version: 5.74.0 Qt Version: 5.14.2 ADDITIONAL INFORMATION
*** Bug 442813 has been marked as a duplicate of this bug. ***
Created attachment 168038 [details] Before / After
I was hoping to patch this but it looks already corrected here: https://invent.kde.org/games/knights/-/commit/bc828eb7e7ec50392b0bfe9118bb367d84d540a7 If confirmed can we close? My failing build as delivered in my distro & and my succeeding clean build off kdesrc (no patches of my own).
(In reply to Mark Capella from comment #3) > I was hoping to patch this but it looks already corrected here: > https://invent.kde.org/games/knights/-/commit/ > bc828eb7e7ec50392b0bfe9118bb367d84d540a7 > > If confirmed can we close? That commit only disable the sounds played when moving the pieces. This bug report about not being able to disable the spoken voice for the actual moves ("pawn to d4", etc.). To reproduce this problem you need to have knights compiled with Qt6SpeechToText engine installed. We need to add an additional option that will allow to disable the voice similar to how it's already possible to disable the move sounds. This option should only be shown if the application was compiled with Qt6SpeechToText. The relevant logic is in gamemanager.cpp (search for #ifdef HAVE_SPEECH) and I see already it's being checked via Settings::speakOpponentsMoves() but the setting itself is not available in the settings dialog (anymore?). Do you want to prepare a patch for this?
Sure! It looks like this changeset: https://invent.kde.org/markcapella/knights/-/commit/fe457fe5af3b99e59206dfb6e2d266ccc264cbce
(In reply to Mark Capella from comment #5) > Sure! It looks like this changeset: > https://invent.kde.org/markcapella/knights/-/commit/ > fe457fe5af3b99e59206dfb6e2d266ccc264cbce This goes into the proper direction, yes. I added a comment under your commit now. Let's finalize everything there.
I've had to refresh my repo after botching it locally. Here's a new commit: https://invent.kde.org/markcapella/knights/-/commit/551027d73e05928c85a5a3d84d2078d463fa1c49
I'd like to also suggest https://invent.kde.org/markcapella/knights/-/commit/248010a9a134c4268bce0ae518e4a94b723e50af Which removes leftover qDebug STDERR message. "background key "Background"" And corrects three STDERR messages generated on open of Settings -> Configure Knights. "edit: editing failed" "edit: editing failed" "edit: editing failed"
I had fun learning how to add that panel ! :B Ok, this is simpler :) https://invent.kde.org/markcapella/knights/-/commit/4228eb38be92ce125e363b7a1d188a1364dd088a
(In reply to Mark Capella from comment #8) > I'd like to also suggest > https://invent.kde.org/markcapella/knights/-/commit/ > 248010a9a134c4268bce0ae518e4a94b723e50af > > Which removes leftover qDebug STDERR message. > "background key "Background"" > > And corrects three STDERR messages generated on open of Settings -> > Configure Knights. > "edit: editing failed" > "edit: editing failed" > "edit: editing failed" The link doesn't seem to work for me anymore. Please create a new MR and we finalize this other topic separately.