Bug 429622 - Re-enable “show password” button on login screen
Summary: Re-enable “show password” button on login screen
Status: CONFIRMED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: master
Platform: Other Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: visual-design
URL: https://phabricator.kde.org/D9040
Keywords: usability
: 442869 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-11-25 06:37 UTC by Manuel Strehl
Modified: 2024-10-16 18:33 UTC (History)
12 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Strehl 2020-11-25 06:37:07 UTC
The changeset in https://phabricator.kde.org/D9040 removed the “reveal password” button on the login screen. For me this is a notable regression.

Copying my comment from Phabricator:

My use case are children aged 7-10 logging in on a desktop PC. They are not completely firm in keyboard usage and need some kind of help to enter their passwords. The “reveal password” button is essential for them being able to log in theirselves.

The missing button was immediately noticed by them after a Kubuntu 18.04 => 20.04 upgrade.

I understand the case for consistency, but at the same time I assume other groups of users, like elderly or persons with Parkinson’s or poor eyesight, would also benefit from re-adding the button.
Comment 1 Nate Graham 2020-11-30 20:45:46 UTC
I have the same child-related use case and your complaint makes sense to me.

We can re-consider.
Comment 2 Andres Betts 2020-12-01 03:41:01 UTC
I understand the use case. I think it is sensible. I feel there "should" be a setting that enables this in the lock screen. However, I also believe, this button could be a potential security risk. Because of that, I would suggest having a setting for the lock screen that a user can enable/disable to have the reveal button back. The setting should contain a warning letting the user know the potential risk and allow the user to continue.
Comment 3 David Edmundson 2020-12-01 23:40:15 UTC
>We can re-consider.

The amount of other bugs the other thing received was quite substantial. I don't want to blindly re-add it. What Andres said might be doable.

In either case, we need the icon problem solved before it goes back; that was the biggest problem with it.
Comment 4 MountainX 2020-12-04 03:21:52 UTC
I support re-adding it. It's essential for us. We had no problems with it. But removing it has caused me lots of support headaches. I vote for putting it back as-is and then work on addressing the issues without removing essential functionality. Thank you.
Comment 5 Bharadwaj Raju 2021-10-01 15:52:39 UTC
*** Bug 442869 has been marked as a duplicate of this bug. ***
Comment 6 61kylyqt 2021-10-03 20:21:59 UTC
There are some comments in bug https://bugs.kde.org/show_bug.cgi?id=442869 that might be useful for this bug report:

https://bugs.kde.org/show_bug.cgi?id=442869#c3
https://bugs.kde.org/show_bug.cgi?id=442869#c4
Comment 7 Filip Fila 2024-10-16 10:55:16 UTC
I checked how the login screen works when re-enabling this button and the icon shows up, if that was the main issue?
Comment 8 David Edmundson 2024-10-16 16:25:10 UTC
>I checked how the login screen works when re-enabling this button and the icon shows up, if that was the main issue?

One issue was SDDM didn't load the icon and we want them in sync.
Comment 9 Filip Fila 2024-10-16 17:07:18 UTC
(In reply to David Edmundson from comment #8)
> >I checked how the login screen works when re-enabling this button and the icon shows up, if that was the main issue?
> 
> One issue was SDDM didn't load the icon and we want them in sync.

I'm actually not seeing the reveal password icon on the *lock* screen when using the (light) Breeze theme, but the button shows up on the login screen for me.

Breeze global theme: https://i.ibb.co/xXPZt1c/Breeze-Login-Screen.jpg
Breeze Dark global theme: https://i.ibb.co/Ct5SNxJ/Third-Party-Login-Screen.jpg

It only fails when the combination of a dark Plasma theme + icon theme with missing icons are synced to the login screen, which is bug 494534 and isn't specific to the reveal password icon.
Example: https://i.ibb.co/bK4SPLw/Breeze-Dark-Login-Screen.jpg
Comment 10 Filip Fila 2024-10-16 17:20:52 UTC
And the same when restoring SDDM to default theme settings: https://i.ibb.co/qB3Qx93/SDDM-Factory-Settings.jpg

The components have been reworked since the button was disabled so maybe that helped. It used to be a PlasmaComponents2.TextField, now it's a PlasmaExtras.PasswordField.
Comment 11 Nate Graham 2024-10-16 18:33:46 UTC
Yeah, looks like there's just Bug 494534 now which is a general pre-existing issue, not an issue specific to that button.