Bug 429574 - Smileys & Emotion category missing from Emoji Selector sidebar
Summary: Smileys & Emotion category missing from Emoji Selector sidebar
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Unclassified
Component: Emoji Selector (show other bugs)
Version: 5.20.3
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-24 00:59 UTC by skierpage
Modified: 2020-11-24 16:01 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.20.4


Attachments
Emoji Selector with sidebar expanded showing no icon for Smiles & Emotion (107.63 KB, image/png)
2020-11-24 00:59 UTC, skierpage
Details

Note You need to log in before you can comment on or make changes to this bug.
Description skierpage 2020-11-24 00:59:38 UTC
Created attachment 133598 [details]
Emoji Selector with sidebar expanded showing no icon for Smiles & Emotion

SUMMARY
See Summary

STEPS TO REPRODUCE
1. Press [Meta+.] to launch Emoji Selector

OBSERVED RESULT
There's no category for smileys, the most basic emoji! But if you click the [|+] sidebar button at the bottom left, the sidebar expands to show text titles, and a "Smileys & Emotion" category with no icon appears.

EXPECTED RESULT
Smileys & Emotion should show up in the default collapsed sidebar with an icon.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora 33 KDE Spin.
KDE Plasma Version: 5.20.3
KDE Frameworks Version: 5.75.0
Qt Version: 5.15.1 xcb

ADDITIONAL INFORMATION
There's no tooltip for the open sidebar button.
Comment 1 skierpage 2020-11-24 07:02:09 UTC
I hoped this might be an easy fix by inspection...
https://invent.kde.org/plasma/plasma-desktop/-/blob/master/applets/kimpanel/backend/ibus/emojier/ui/CategoryAction.qml#L32 has

    function getIcon(category) {
        switch (category.trim()) {
            ...
            case 'People & Body': return 'user'
            case 'Smileys & Emotion': Q_FALLTHROUGH
            case 'Smileys & People': return 'smiley'
            case 'Symbols': return 'love'
            ...

So the icon for the "Smileys & Emotion" category in the sidebar should be 'smiley', I think I'm using the breeze theme, and I have a /usr/share/icons/breeze/actions/22/smiley.svg ; I changed System Settings > Appearance > Icons to Oxygen and still no icon. Hmmm.
Comment 2 Bug Janitor Service 2020-11-24 10:49:30 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/243
Comment 3 David Redondo 2020-11-24 12:08:09 UTC
Git commit 6e66bf62bbf800443d69a172cc1db24e88145e8f by David Redondo.
Committed on 24/11/2020 at 10:31.
Pushed by davidre into branch 'master'.

There is no Q_FALLTHROUGH in qml or js
CCMAIL:i@guoyunhe.me

M  +1    -1    applets/kimpanel/backend/ibus/emojier/ui/CategoryAction.qml

https://invent.kde.org/plasma/plasma-desktop/commit/6e66bf62bbf800443d69a172cc1db24e88145e8f
Comment 4 Nate Graham 2020-11-24 16:00:44 UTC
Git commit 980b22d518e0cfcfba376c01bc43cc7454317904 by Nate Graham, on behalf of David Redondo.
Committed on 24/11/2020 at 16:00.
Pushed by ngraham into branch 'Plasma/5.20'.

There is no Q_FALLTHROUGH in qml or js
CCMAIL:i@guoyunhe.me


(cherry picked from commit 6e66bf62bbf800443d69a172cc1db24e88145e8f)

M  +1    -1    applets/kimpanel/backend/ibus/emojier/ui/CategoryAction.qml

https://invent.kde.org/plasma/plasma-desktop/commit/980b22d518e0cfcfba376c01bc43cc7454317904