Bug 429501 - Lock the recursive button when not applicable to make it less confusing
Summary: Lock the recursive button when not applicable to make it less confusing
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Transform (show other bugs)
Version: 4.4.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-22 13:53 UTC by Raghavendra kamath
Modified: 2021-05-31 12:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Raghavendra kamath 2020-11-22 13:53:52 UTC
SUMMARY
The work recursively button in the tool option docker of the transform tool doesn't seem to do anything if enabled or disabled. The transform shows no difference in both cases.

STEPS TO REPRODUCE
1. Open Krita and a new document in it.
2. Add a group layer and add some layer inside it. Draw on each layer inside the group
3. select the parent group and activate transform tool. No enable the spider icon to work recursively and transform the group. Repeat the same step without the spider icon enabled.

OBSERVED RESULT
In both cases layers inside group are transformed recursively

EXPECTED RESULT
I am not sure if this should be an option. Groups should be transformed recursively no matter what. May be I am understanding this option incorrectly.
Comment 1 tomtomtomreportingin 2021-03-11 07:14:47 UTC
I can confirm this. Seems it happens as far as 4.1, and I haven't checked versions previous to that.
Comment 2 tomtomtomreportingin 2021-03-11 07:43:41 UTC
After clarification from Dmitry, it seems this isn't a problem of broken functionality but rather unclear documentation. As noted in the IRC, the option is automatically used on non-paintable layers like group layers, so changing the setting only changes when working with paint layers with masks, for example.

As suggested in  the IRC, the button should be locked where it isn't applicable.
Comment 3 Raghavendra kamath 2021-03-11 07:50:07 UTC
I changed the title of this bug after Dmitry's suggestion in the chatroom. The button should be disabled or locked when it is not applicable. It only works on paint layers with masks.
Comment 4 Raghavendra kamath 2021-03-11 07:51:13 UTC
As per tomtom's suggestion we should change the text of the tooltip to more clearly explain the feature.
Comment 5 Dmitry Kazakov 2021-05-31 12:54:29 UTC
Git commit 93faf98fb81b8a674bf5200469b35a88149a0470 by Dmitry Kazakov, on behalf of Srirupa Datta.
Committed on 31/05/2021 at 12:54.
Pushed by dkazakov into branch 'master'.

Remove work recursively button

All layers and groups work recursively now. To achieve  unrecursive
behaviour, lock the layer/mask.

GUI:
FIXED IN: 5.0.0

M  +9    -15   plugins/tools/tool_transform2/kis_tool_transform.cc
M  +1    -2    plugins/tools/tool_transform2/kis_tool_transform.h
M  +2    -11   plugins/tools/tool_transform2/kis_tool_transform_config_widget.cpp
M  +1    -2    plugins/tools/tool_transform2/kis_tool_transform_config_widget.h
M  +4    -4    plugins/tools/tool_transform2/kis_transform_utils.cpp
M  +1    -1    plugins/tools/tool_transform2/kis_transform_utils.h
M  +1    -4    plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.cpp
M  +0    -1    plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.h
M  +2    -3    plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp
M  +0    -2    plugins/tools/tool_transform2/strokes/transform_stroke_strategy.h
M  +18   -31   plugins/tools/tool_transform2/wdg_tool_transform.ui

https://invent.kde.org/graphics/krita/commit/93faf98fb81b8a674bf5200469b35a88149a0470