Bug 429500 - cannot remove shortcuts
Summary: cannot remove shortcuts
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kdeclarative
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.76.0
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
: 431370 432015 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-11-22 13:42 UTC by Patrick Silva
Modified: 2021-01-26 03:33 UTC (History)
6 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/commit/e808020837a113cefd62b7ce198a3c021856d1ed
Version Fixed In: 5.21

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-11-22 13:42:29 UTC 
SUMMARY
reproducible at least with media player, plasma-pa (sound) and battery applets

STEPS TO REPRODUCE
1. open the settings window of any system tray applet mentioned above
and click on its "Keyboard Shortcuts" section
2. assign any shortcut and click on "Apply" button
3. remove the just assigned shortcut (notice that "Apply" button remains greyed out)
4. click on "Ok" button
5. press the shortcut that you tried to remove in the step 3: it works
6. reopen applet settings, "Keyboard shortcuts" section: the shortcut is still
assigned

EXPECTED RESULT
we should be able to remove shortcuts of system tray applets

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.77.0
Qt Version: 5.15.1
Comment 1 Nate Graham 2020-11-23 20:35:32 UTC 
Can confirm all of that. Seems like an issue in the QML-based shortcut component.
Comment 2 Patrick Silva 2021-01-16 13:05:25 UTC 
Not only systray applets are affected. I also can not remove a shortcut to toggle "do not disturb" mode in Notifications KCM, for example.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2
Comment 3 Nate Graham 2021-01-16 14:25:38 UTC 
*** Bug 431370 has been marked as a duplicate of this bug. ***
Comment 4 David Redondo 2021-01-20 15:51:12 UTC 
Git commit e808020837a113cefd62b7ce198a3c021856d1ed by David Redondo.
Committed on 20/01/2021 at 15:49.
Pushed by davidre into branch 'master'.

Allow to clear applet shortcuts again

captureFinished only fires if a capture was done, when pressing the clear it is
not emitted. So we have to go back to listening for keySequence changes and
comparing the keySequence to not emit configurationChanged on initial load.

M  +3    -1    desktoppackage/contents/configuration/ConfigurationShortcuts.qml

https://invent.kde.org/plasma/plasma-desktop/commit/e808020837a113cefd62b7ce198a3c021856d1ed
Comment 5 David Redondo 2021-01-20 15:51:20 UTC 
Git commit adb03fe893e2c8c35d5e8b14dc308da8976ed5c0 by David Redondo.
Committed on 20/01/2021 at 15:49.
Pushed by davidre into branch 'master'.

Revert "Use captureFinished signal"

This reverts commit 9aa7f986a2428073eb2c5d6397454689432f8113.

M  +1    -1    desktoppackage/contents/configuration/ConfigurationShortcuts.qml

https://invent.kde.org/plasma/plasma-desktop/commit/adb03fe893e2c8c35d5e8b14dc308da8976ed5c0
Comment 6 Patrick Silva 2021-01-22 10:20:20 UTC 
The bug with applets is fixed on neon unstable, but KCMs like Notifications and
Screen Locking are still affected. Shoul I open another bug report?
Comment 7 Nate Graham 2021-01-25 16:33:21 UTC 
Yes please.
Comment 8 Patrick Silva 2021-01-25 17:27:12 UTC 
done, see bug 432106
Comment 9 Nate Graham 2021-01-26 03:33:26 UTC 
*** Bug 432015 has been marked as a duplicate of this bug. ***