Bug 429460 - Clicking on an mp3 in folder section leads to "recently played"
Summary: Clicking on an mp3 in folder section leads to "recently played"
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: 20.08.3
Platform: Other Other
: VHI wishlist
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-11-21 16:40 UTC by postix
Modified: 2020-12-04 00:12 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 20.12.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2020-11-21 16:40:10 UTC
STEPS TO REPRODUCE
1. Folder: Go to your music folder with mp3s
2. Click on one of your mp3s with a single click (not on the play icon)

OBSERVED RESULT

Elisa goes to the "recently played" section.


EXPECTED RESULT

Elisa plays the song or adds it to the playlist and stays in the folder section.


SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux
KDE Plasma Version: 5.20.3
KDE Frameworks Version: 5.76.0
Qt Version: 5.15.1
Comment 1 Nate Graham 2020-11-23 18:24:01 UTC
Whoa darn, can reproduce. :(
Comment 2 Bug Janitor Service 2020-12-01 22:33:12 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/196
Comment 3 Nate Graham 2020-12-03 18:43:07 UTC
Git commit 35b6a6a81e4cf0cfa1f6d74726a49933f05ccc05 by Nate Graham, on behalf of Matthieu Gallien.
Committed on 03/12/2020 at 18:42.
Pushed by ngraham into branch 'release/20.12'.

in grid view, do not try to open music files but enqueue them

in the file browser, it was possible to try to open music files leading
to an invalid state. ensure they will be queued to the playlist instead
of open as if they had children

M  +1    -0    src/datatypes.h
M  +22   -0    src/models/datamodel.cpp
M  +2    -0    src/models/filebrowsermodel.cpp
M  +3    -2    src/qml/GridBrowserDelegate.qml
M  +1    -0    src/qml/GridBrowserView.qml

https://invent.kde.org/multimedia/elisa/commit/35b6a6a81e4cf0cfa1f6d74726a49933f05ccc05