Created attachment 133477 [details] screenshot Latest git master, see screenshot (sorry for the gif, doesn't seem like KDE1's ksnapshot supports png's).
Just fixed ten minutes ago! :) Bleeding edge can cut ya from time to time
Aww, and I spent ten minutes getting a KDE 1 session up and running for the session. (But thanks!)
Hmm, still seems to be here on commit e36de310cbdc60434dd15efbb52e18266a566a28. Dug into it a bit, and seems like the URL navigator is part of the toolbar now? I have the toolbar hidden, so that might be the issue? Or at least related (I haven't reviewed the new urlnavigator code).
And maybe unrelated, but the toolbar in Konsole has suddenly started popping up, and the setting to hide it is gone. Has there been any general KXmlGui-toolbar-work done recently?
Aha, you found a corner case. Yes, the URL navigator is now in the toolbar by default, but we restore it to its prior non-toolbar position when it's been *removed* from the toolbar, but not when the toolbar is simply hidden. Felix, could I ask you to look into this? Thanks! --- Konsole is unrelated and you should be able to hide the toolbar by going to Settings > Toolbars Shown > Uncheck everything
Seems like the issue with konsole was that I launched a newer build of konsole, and then tried to start an older (system-installed) version. That apparently wrote something to an rc file that made the older version (which doesn't have the toolbar settings in the menu) show the toolbar. So ignore that issue, I guess it's self-inflicted. :-)
The bug originally reported here is fixed I believe. With 50ca5af7e0ec460f9f004a3660efa10bb1dd8cb1 the UrlNavigator is no longer moved into the toolbar automatically by upgrading. So the UrlNavigator will then still be visible where it was previously even if users have the toolbar hidden. About the corner case of what to do when hiding the toolbar when it contains the UrlNavigator: There are two ways to think about this imho: - A UrlNavigator should always be visible. So hiding the toolbar and therefore hiding the UrlNavigator is a bug. With that logic it should pop up below the tab bar. - A user that hides the toolbar really does want to have all vertical space they can get. Having the UrlNavigator appear in that case would counteract exactly what the user is trying to do. (This is how it is currently.) I think the current approach makes more sense. It doesn't assume what a user wants to do. A bonus of the current approach is that users can have either a configuration with a hidden toolbar and a visible UrlNavigator or one with a hidden toolbar but an invisible UrlNavigator. If we were to decide that an UrlNavigator always needs to be visible, hiding both becomes impossible and maybe a user wants to do exactly that. Anyways I don't think we have to surprise users with a UrlNavigator appearing elsewhere when the toolbar is hidden.
With "(This is how it is currently.)" I meant that hiding the toolbar does exactly that and nothing else. I noticed that can be read the wrong way. ^^
> we restore it to its prior non-toolbar position when it's been *removed* from the toolbar, but not when the toolbar is simply hidden. Hmm, I tried removing it from the toolbar, but it's still not showing up. And restarting Dolphin it pops back into the toolbar. (And I turned toolbars back to visible before testing this.)
(In reply to Martin Sandsmark from comment #6) > Seems like the issue with konsole was that I launched a newer build of > konsole, and then tried to start an older (system-installed) version. That > apparently wrote something to an rc file that made the older version (which > doesn't have the toolbar settings in the menu) show the toolbar. > > So ignore that issue, I guess it's self-inflicted. :-) Yes this is an annoying issue with KXMLGui, probably worth fixing. > Anyways I don't think we have to surprise users with a UrlNavigator appearing > elsewhere when the toolbar is hidden. OK. Fair enough. If we get more bug reports, I'm gonna dupe them to this and re-open it, though. :)
@Martin Sandsmark For some reason Elvis Angelaccio merged the commit only into release and not into master. It's probably just an oversight but I didn't ask him. >If we get more bug reports, I'm gonna dupe them to this and re-open it, though. :) I mean sure. If you ever think this will need more discussion re-open it. I would expect more bug reports though if it were the other way around but maybe I am misjudging.
Probably an oversight; people forget to merge back to stable all the time, which is one of the reasons why I prefer the cherry-pick workflow. There's nothing to forget since putting it on the stable branch is a deliberate action you take after merging to master. Either way I have performed the merge.